Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.cc

Issue 2777093009: [Memory UMA] Return a memory summary struct with the ack message (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.cc
diff --git a/services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.cc b/services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.cc
index b93dd6f16e1ca06b47abafbd177da7d08ab3d4f4..1129bae1d1146bc5e475a59c2d7523acca891fe8 100644
--- a/services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.cc
+++ b/services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.cc
@@ -50,7 +50,7 @@ void MemoryDumpManagerDelegateImpl::RequestProcessMemoryDump(
void MemoryDumpManagerDelegateImpl::RequestGlobalMemoryDump(
const base::trace_event::MemoryDumpRequestArgs& args,
- const base::trace_event::MemoryDumpCallback& callback) {
+ const base::trace_event::GlobalMemoryDumpCallback& callback) {
// Note: This condition is here to match the old behavior. If the delegate is
// in the browser process, we do not drop parallel requests in the delegate
// and so they will be queued by the Coordinator service (see
@@ -81,7 +81,7 @@ void MemoryDumpManagerDelegateImpl::RequestGlobalMemoryDump(
}
void MemoryDumpManagerDelegateImpl::MemoryDumpCallbackProxy(
- const base::trace_event::MemoryDumpCallback& callback,
+ const base::trace_event::GlobalMemoryDumpCallback& callback,
uint64_t dump_guid,
bool success) {
DCHECK_NE(0U, pending_memory_dump_guid_);

Powered by Google App Engine
This is Rietveld 408576698