services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc - Issue 2777093009: [Memory UMA] Return a memory summary struct with the ack message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc

Issue 2777093009: [Memory UMA] Return a memory summary struct with the ack message (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « services/resource_coordinator/memory/coordinator/coordinator_impl.cc ('k') | services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc

diff --git a/services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc b/services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc

index e19c3c2f391d769b9b6868c86651cbd7f4c4a514..521f8f205cfa7768812575e1d449ab209dca0660 100644

--- a/services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc

+++ b/services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc

@@ -82,7 +82,8 @@ class MockDumpManager : public mojom::ProcessLocalDumpManager {

const base::trace_event::MemoryDumpRequestArgs& args,

const RequestProcessMemoryDumpCallback& callback) override {

expected_calls_--;

- callback.Run(args.dump_guid, true);

+ base::trace_event::MemoryDumpCallbackResult result;

+ callback.Run(args.dump_guid, true, result);

}

private: