Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2777093005: Repaint overlay scrollbar if resource is disposed. (Closed)

Created:
3 years, 9 months ago by bokan
Modified:
3 years, 8 months ago
Reviewers:
weiliangc
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Repaint overlay scrollbar if resource is disposed. The previously painted resource can be disposed as the layer is attached/detached from the LayerTreeHost. This isn't reflected by the NeedsPaint status on the Blink-side Scrollbar so the scrollbar layer should ignore the NeedsPaint status if it hasn't painted into its UIResource yet. BUG=704656 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2777093005 Cr-Commit-Position: refs/heads/master@{#460188} Committed: https://chromium.googlesource.com/chromium/src/+/afaccab374bddd9bfc6e3609806da73860a5ba7d

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : Formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -1 line) Patch
M cc/layers/painted_overlay_scrollbar_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 1 2 2 chunks +70 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
bokan
ptal
3 years, 8 months ago (2017-03-28 14:10:08 UTC) #9
weiliangc
LGTM
3 years, 8 months ago (2017-03-28 19:26:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777093005/40001
3 years, 8 months ago (2017-03-28 19:28:50 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 19:34:17 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/afaccab374bddd9bfc6e3609806d...

Powered by Google App Engine
This is Rietveld 408576698