Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2777083002: Revert of Mojo JS bindings: support auto-loading mojom.js deps. (Closed)

Created:
3 years, 9 months ago by hayato
Modified:
3 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, blink-reviews, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mojo JS bindings: support auto-loading mojom.js deps. (patchset #3 id:40001 of https://codereview.chromium.org/2779493002/ ) Reason for revert: It looks we have to revert this CL too in order to revert https://codereview.chromium.org/2759563004/. The previous revert failed in: https://codereview.chromium.org/2779533002/ Original issue's description: > Mojo JS bindings: support auto-loading mojom.js deps. > > It also adds a config to turn off this behavior. > > BUG=699569 > > Review-Url: https://codereview.chromium.org/2779493002 > Cr-Commit-Position: refs/heads/master@{#459695} > Committed: https://chromium.googlesource.com/chromium/src/+/e326a5d409dadb3df6811b3dca7f1cfecb4ef520 TBR=rockot@chromium.org,yzshen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=699569 Review-Url: https://codereview.chromium.org/2777083002 Cr-Commit-Position: refs/heads/master@{#459724} Committed: https://chromium.googlesource.com/chromium/src/+/ae2b29ed27f84f0209be6f0482f5b85c0578ee75

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -131 lines) Patch
M mojo/public/js/new_bindings/base.js View 2 chunks +0 lines, -78 lines 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl View 2 chunks +3 lines, -19 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_js_generator.py View 3 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/mojo/module-loading.html View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/mojo/module-loading-manual-deps-loading.html View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
hayato
Created Revert of Mojo JS bindings: support auto-loading mojom.js deps.
3 years, 9 months ago (2017-03-27 08:47:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777083002/1
3 years, 9 months ago (2017-03-27 08:47:37 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 08:49:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ae2b29ed27f84f0209be6f0482f5...

Powered by Google App Engine
This is Rietveld 408576698