Mojo JS bindings: support auto-loading mojom.js deps.

Mojo JS bindings: support auto-loading mojom.js deps.

It also adds a config to turn off this behavior.

BUG=699569
Review-Url: https://codereview.chromium.org/2779493002
Cr-Commit-Position: refs/heads/master@{#461354}
Committed: https://chromium.googlesource.com/chromium/src/+/b8e4332ca05f3220a36557b0e25dd3fa75365672

[yzshen1, 2017-03-26 08:23:32]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-26 08:23:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-26 10:30:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-26 10:31:00]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[yzshen1, 2017-03-26 17:26:38]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-26 17:26:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2017-03-26 17:28:30]

Description was changed from

==========
Mojo JS bindings: support auto-loading dependent mojom.js files.

BUG=699569
==========

to

==========
Mojo JS bindings: support auto-loading mojom.js deps.

It also adds a config to turn off this behavior.

BUG=699569
==========

[yzshen1, 2017-03-26 17:28:30]

yzshen@chromium.org changed reviewers:
+ rockot@chromium.org

[yzshen1, 2017-03-26 17:28:47]

Hi, Ken.

Would you please take a look? Thanks!

[Ken Rockot(use gerrit already), 2017-03-26 18:27:11]

lgtm

https://codereview.chromium.org/2779493002/diff/20001/mojo/public/js/new_bind...
File mojo/public/js/new_bindings/base.js (right):

https://codereview.chromium.org/2779493002/diff/20001/mojo/public/js/new_bind...
mojo/public/js/new_bindings/base.js:16: // For example, if foo.mojom imports
bar.mojom, |auto_load_mojom_deps| sets
not: sets -> set

https://codereview.chromium.org/2779493002/diff/20001/mojo/public/js/new_bind...
mojo/public/js/new_bindings/base.js:48: auto_load_mojom_deps: true
not: shouldn't this be autoLoadMojomDeps?

[commit-bot: I haz the power, 2017-03-26 18:50:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-26 18:50:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yzshen1, 2017-03-26 19:51:11]

Thanks! :)

https://codereview.chromium.org/2779493002/diff/20001/mojo/public/js/new_bind...
File mojo/public/js/new_bindings/base.js (right):

https://codereview.chromium.org/2779493002/diff/20001/mojo/public/js/new_bind...
mojo/public/js/new_bindings/base.js:16: // For example, if foo.mojom imports
bar.mojom, |auto_load_mojom_deps| sets
On 2017/03/26 18:27:11, Ken Rockot wrote:
> not: sets -> set

Done.

https://codereview.chromium.org/2779493002/diff/20001/mojo/public/js/new_bind...
mojo/public/js/new_bindings/base.js:48: auto_load_mojom_deps: true
On 2017/03/26 18:27:11, Ken Rockot wrote:
> not: shouldn't this be autoLoadMojomDeps?

Yes! :) I am too used to C++...

[yzshen1, 2017-03-26 19:51:17]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2017-03-26 19:51:18]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2779493002/#ps40001
(title: ".")

[commit-bot: I haz the power, 2017-03-26 19:51:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-26 21:31:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-26 21:31:11]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yzshen1, 2017-03-26 22:17:49]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2017-03-26 22:18:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 01:41:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 01:41:16]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yzshen1, 2017-03-27 01:52:54]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2017-03-27 01:53:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 03:19:26]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490579574587470,
"parent_rev": "edb2d15c8a542b5e7ee88fd49a055b4a8d62ff56", "commit_rev":
"e326a5d409dadb3df6811b3dca7f1cfecb4ef520"}

[commit-bot: I haz the power, 2017-03-27 03:20:46]

Description was changed from

==========
Mojo JS bindings: support auto-loading mojom.js deps.

It also adds a config to turn off this behavior.

BUG=699569
==========

to

==========
Mojo JS bindings: support auto-loading mojom.js deps.

It also adds a config to turn off this behavior.

BUG=699569

Review-Url: https://codereview.chromium.org/2779493002
Cr-Commit-Position: refs/heads/master@{#459695}
Committed:
https://chromium.googlesource.com/chromium/src/+/e326a5d409dadb3df6811b3dca7f...
==========

[commit-bot: I haz the power, 2017-03-27 03:20:47]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e326a5d409dadb3df6811b3dca7f...

[hayato, 2017-03-27 08:47:23]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2777083002/ by hayato@chromium.org.

The reason for reverting is: It looks we have to revert this CL too in order to
revert https://codereview.chromium.org/2759563004/.

The previous revert failed in: https://codereview.chromium.org/2779533002/.

[yzshen1, 2017-04-02 06:31:38]

Description was changed from

==========
Mojo JS bindings: support auto-loading mojom.js deps.

It also adds a config to turn off this behavior.

BUG=699569

Review-Url: https://codereview.chromium.org/2779493002
Cr-Commit-Position: refs/heads/master@{#459695}
Committed:
https://chromium.googlesource.com/chromium/src/+/e326a5d409dadb3df6811b3dca7f...
==========

to

==========
Mojo JS bindings: support auto-loading mojom.js deps.

It also adds a config to turn off this behavior.

BUG=699569

Review-Url: https://codereview.chromium.org/2779493002
Cr-Commit-Position: refs/heads/master@{#459695}
Committed:
https://chromium.googlesource.com/chromium/src/+/e326a5d409dadb3df6811b3dca7f...
==========

[yzshen1, 2017-04-02 06:49:03]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-02 06:49:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-02 09:40:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-02 09:40:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yzshen1, 2017-04-02 23:39:01]

Description was changed from

==========
Mojo JS bindings: support auto-loading mojom.js deps.

It also adds a config to turn off this behavior.

BUG=699569

Review-Url: https://codereview.chromium.org/2779493002
Cr-Commit-Position: refs/heads/master@{#459695}
Committed:
https://chromium.googlesource.com/chromium/src/+/e326a5d409dadb3df6811b3dca7f...
==========

to

==========
Mojo JS bindings: support auto-loading mojom.js deps.

It also adds a config to turn off this behavior.

BUG=699569
==========

[yzshen1, 2017-04-02 23:39:08]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2017-04-02 23:39:08]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2779493002/#ps60001
(title: ".")

[commit-bot: I haz the power, 2017-04-02 23:39:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 00:51:45]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491176348352960,
"parent_rev": "9e03960f75b3019372157db5c4fe5264dfc36616", "commit_rev":
"b8e4332ca05f3220a36557b0e25dd3fa75365672"}

[commit-bot: I haz the power, 2017-04-03 00:53:07]

Description was changed from

==========
Mojo JS bindings: support auto-loading mojom.js deps.

It also adds a config to turn off this behavior.

BUG=699569
==========

to

==========
Mojo JS bindings: support auto-loading mojom.js deps.

It also adds a config to turn off this behavior.

BUG=699569

Review-Url: https://codereview.chromium.org/2779493002
Cr-Commit-Position: refs/heads/master@{#461354}
Committed:
https://chromium.googlesource.com/chromium/src/+/b8e4332ca05f3220a36557b0e25d...
==========

[commit-bot: I haz the power, 2017-04-03 00:53:08]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b8e4332ca05f3220a36557b0e25d...

[findit-for-me, 2017-04-03 02:43:38]

Findit identified this CL at revision 461354 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[yzshen1, 2017-04-03 03:29:42]

On 2017/04/03 02:43:38, findit-for-me wrote:
> Findit identified this CL at revision 461354 as the culprit for
> failures in the build cycles as shown on:
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Looking at the failure. It seems very unlikely to me.

This CL changes a JavaScript library (mojo_bindings.js) that is just used by the
two layout tests module-loading.html and
module-loading-manual-deps-loading.html. It shouldn't have any effect outside of
those two tests.