Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 2776973005: Revert of Remove some pre-md code and assets. (Closed)

Created:
3 years, 9 months ago by jwd
Modified:
3 years, 9 months ago
Reviewers:
tdanderson, Evan Stade
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove some pre-md code and assets. (patchset #3 id:40001 of https://codereview.chromium.org/2770953003/ ) Reason for revert: Causing failures on chromium.chromiumos/Linux ChromiumOS Tests (dbg)(1) BUG=705678 Original issue's description: > Remove some pre-md code and assets. > > BUG=687816, 686234, 686335 > > Review-Url: https://codereview.chromium.org/2770953003 > Cr-Commit-Position: refs/heads/master@{#459837} > Committed: https://chromium.googlesource.com/chromium/src/+/36cfbe932ed734d1935b8eeb9273aff1b80c598c TBR=tdanderson@chromium.org,estade@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=687816, 686234, 686335 Review-Url: https://codereview.chromium.org/2776973005 Cr-Commit-Position: refs/heads/master@{#459887} Committed: https://chromium.googlesource.com/chromium/src/+/cd95e0083676d5e1b82a3bad0c2ccef61b557230

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+443 lines, -95 lines) Patch
M ash/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/common/system/chromeos/brightness/tray_brightness.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M ash/common/system/chromeos/power/power_status.h View 5 chunks +54 lines, -17 lines 0 comments Download
M ash/common/system/chromeos/power/power_status.cc View 6 chunks +122 lines, -42 lines 0 comments Download
M ash/common/system/chromeos/power/power_status_unittest.cc View 2 chunks +28 lines, -29 lines 0 comments Download
M ash/common/system/chromeos/session/tray_session_length_limit.cc View 3 chunks +4 lines, -5 lines 0 comments Download
A ash/common/system/chromeos/settings/tray_settings.h View 1 chunk +40 lines, -0 lines 0 comments Download
A ash/common/system/chromeos/settings/tray_settings.cc View 1 chunk +175 lines, -0 lines 0 comments Download
M ash/common/system/tray/system_tray.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M ash/resources/ash_resources.grd View 1 chunk +7 lines, -0 lines 0 comments Download
A ash/resources/default_100_percent/cros/notification/notification_session_length_timer.png View Binary file 0 comments Download
A ash/resources/default_100_percent/cros/status/status_brightness.png View Binary file 0 comments Download
A ash/resources/default_100_percent/cros/status/status_power_small_all.png View Binary file 0 comments Download
A ash/resources/default_100_percent/cros/status/status_power_small_all_dark.png View Binary file 0 comments Download
A ash/resources/default_100_percent/cros/status/status_power_small_all_dark_fluctuating.png View Binary file 0 comments Download
A ash/resources/default_100_percent/cros/status/status_power_small_all_fluctuating.png View Binary file 0 comments Download
A ash/resources/default_100_percent/cros/status/status_settings.png View Binary file 0 comments Download
A ash/resources/default_200_percent/cros/notification/notification_session_length_timer.png View Binary file 0 comments Download
A ash/resources/default_200_percent/cros/status/status_brightness.png View Binary file 0 comments Download
A ash/resources/default_200_percent/cros/status/status_power_small_all.png View Binary file 0 comments Download
A ash/resources/default_200_percent/cros/status/status_power_small_all_dark.png View Binary file 0 comments Download
A ash/resources/default_200_percent/cros/status/status_power_small_all_dark_fluctuating.png View Binary file 0 comments Download
A ash/resources/default_200_percent/cros/status/status_power_small_all_fluctuating.png View Binary file 0 comments Download
A ash/resources/default_200_percent/cros/status/status_settings.png View Binary file 0 comments Download

Messages

Total messages: 6 (3 generated)
jwd
Created Revert of Remove some pre-md code and assets.
3 years, 9 months ago (2017-03-27 21:12:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776973005/1
3 years, 9 months ago (2017-03-27 21:13:26 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 21:32:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cd95e0083676d5e1b82a3bad0c2c...

Powered by Google App Engine
This is Rietveld 408576698