Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2770953003: Remove some pre-md code and assets. (Closed)

Created:
3 years, 9 months ago by Evan Stade
Modified:
3 years, 8 months ago
Reviewers:
danakj, tdanderson
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some pre-md code and assets. BUG=687816, 686234, 686335 Review-Url: https://codereview.chromium.org/2770953003 Cr-Commit-Position: refs/heads/master@{#459837} Committed: https://chromium.googlesource.com/chromium/src/+/36cfbe932ed734d1935b8eeb9273aff1b80c598c

Patch Set 1 #

Total comments: 8

Patch Set 2 : ta review + rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -426 lines) Patch
M ash/BUILD.gn View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M ash/common/system/chromeos/brightness/tray_brightness.cc View 1 2 chunks +2 lines, -8 lines 0 comments Download
M ash/common/system/chromeos/power/power_status.h View 1 5 chunks +16 lines, -53 lines 0 comments Download
M ash/common/system/chromeos/power/power_status.cc View 1 6 chunks +37 lines, -117 lines 0 comments Download
M ash/common/system/chromeos/power/power_status_unittest.cc View 2 chunks +18 lines, -17 lines 0 comments Download
M ash/common/system/chromeos/session/tray_session_length_limit.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
D ash/common/system/chromeos/settings/tray_settings.h View 1 chunk +0 lines, -40 lines 0 comments Download
D ash/common/system/chromeos/settings/tray_settings.cc View 1 1 chunk +0 lines, -175 lines 0 comments Download
M ash/common/system/tray/system_tray.cc View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M ash/resources/ash_resources.grd View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
D ash/resources/default_100_percent/cros/notification/notification_session_length_timer.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_brightness.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_power_small_all.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_power_small_all_dark.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_power_small_all_dark_fluctuating.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_power_small_all_fluctuating.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_settings.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/notification/notification_session_length_timer.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_brightness.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_power_small_all.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_power_small_all_dark.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_power_small_all_dark_fluctuating.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_power_small_all_fluctuating.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_settings.png View Binary file 0 comments Download

Messages

Total messages: 31 (16 generated)
Evan Stade
3 years, 9 months ago (2017-03-22 22:36:11 UTC) #3
tdanderson
Thanks for taking this. LGTM with nits. https://codereview.chromium.org/2770953003/diff/1/ash/BUILD.gn File ash/BUILD.gn (right): https://codereview.chromium.org/2770953003/diff/1/ash/BUILD.gn#newcode1 ash/BUILD.gn:1: # Copyright ...
3 years, 9 months ago (2017-03-22 23:23:07 UTC) #5
Evan Stade
https://codereview.chromium.org/2770953003/diff/1/ash/BUILD.gn File ash/BUILD.gn (right): https://codereview.chromium.org/2770953003/diff/1/ash/BUILD.gn#newcode1 ash/BUILD.gn:1: # Copyright 2014 The Chromium Authors. All rights reserved. ...
3 years, 9 months ago (2017-03-23 15:55:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770953003/20001
3 years, 9 months ago (2017-03-23 15:56:27 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/390174)
3 years, 9 months ago (2017-03-23 16:15:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770953003/20001
3 years, 9 months ago (2017-03-27 15:08:46 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/180511) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-27 15:11:31 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770953003/40001
3 years, 9 months ago (2017-03-27 16:55:18 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/36cfbe932ed734d1935b8eeb9273aff1b80c598c
3 years, 9 months ago (2017-03-27 18:38:48 UTC) #23
findit-for-me
Findit identified this CL at revision 459837 as the culprit for failures in the build ...
3 years, 9 months ago (2017-03-27 19:51:21 UTC) #24
jwd
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2776973005/ by jwd@chromium.org. ...
3 years, 9 months ago (2017-03-27 21:12:47 UTC) #25
danakj
Hey terry, did this reland on another CL or is there another one I can ...
3 years, 8 months ago (2017-03-29 22:08:02 UTC) #28
danakj
On 2017/03/29 22:08:02, danakj wrote: > Hey terry, did this reland on another CL or ...
3 years, 8 months ago (2017-03-29 22:08:28 UTC) #29
Evan Stade
On 2017/03/29 22:08:28, danakj wrote: > On 2017/03/29 22:08:02, danakj wrote: > > Hey terry, ...
3 years, 8 months ago (2017-03-29 22:36:58 UTC) #30
danakj
3 years, 8 months ago (2017-03-29 22:38:25 UTC) #31
Message was sent while issue was closed.
On Wed, Mar 29, 2017 at 6:36 PM, <estade@chromium.org> wrote:

> On 2017/03/29 22:08:28, danakj wrote:
> > On 2017/03/29 22:08:02, danakj wrote:
> > > Hey terry, did this reland on another CL or is there another one I can
> watch
> > > (I'm waiting to rebase on it)?
> >
> > Oops, or Evan :) I misread reviewer/author.
>
> It has relanded.
>

Cool, thanks!

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698