Remove some pre-md code and assets.

Remove some pre-md code and assets.

BUG=687816, 686234, 686335
Review-Url: https://codereview.chromium.org/2770953003
Cr-Commit-Position: refs/heads/master@{#459837}
Committed: https://chromium.googlesource.com/chromium/src/+/36cfbe932ed734d1935b8eeb9273aff1b80c598c

[Evan Stade, 2017-03-22 22:36:04]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2017-03-22 22:36:10]

estade@chromium.org changed reviewers:
+ tdanderson@chromium.org

[commit-bot: I haz the power, 2017-03-22 22:36:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tdanderson, 2017-03-22 23:23:07]

Thanks for taking this. LGTM with nits.

https://codereview.chromium.org/2770953003/diff/1/ash/BUILD.gn
File ash/BUILD.gn (right):

https://codereview.chromium.org/2770953003/diff/1/ash/BUILD.gn#newcode1
ash/BUILD.gn:1: # Copyright 2014 The Chromium Authors. All rights reserved.
nit: In the cl title or description it would be good to include mention of which
classes / features are being touched. This makes the CL easier to identify (or
rule out) when hunting down a regression.

https://codereview.chromium.org/2770953003/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/power/power_status.cc (right):

https://codereview.chromium.org/2770953003/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/power/power_status.cc:323: // Use ICON_BADGE_ALERT if
the battery is critically low and does not already
nit: "Use an alert badge"

https://codereview.chromium.org/2770953003/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/power/power_status.cc:361: if (info.icon_badge) {
nit: remove {}

https://codereview.chromium.org/2770953003/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/power/power_status.h (right):

https://codereview.chromium.org/2770953003/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/power/power_status.h:91: // An alert badge is drawn
over the material design battery icon if the
nit: omit "material design" in comment

[commit-bot: I haz the power, 2017-03-22 23:23:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 23:23:18]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2017-03-23 15:55:37]

https://codereview.chromium.org/2770953003/diff/1/ash/BUILD.gn
File ash/BUILD.gn (right):

https://codereview.chromium.org/2770953003/diff/1/ash/BUILD.gn#newcode1
ash/BUILD.gn:1: # Copyright 2014 The Chromium Authors. All rights reserved.
On 2017/03/22 23:23:07, tdanderson wrote:
> nit: In the cl title or description it would be good to include mention of
which
> classes / features are being touched. This makes the CL easier to identify (or
> rule out) when hunting down a regression.

I think the file names pretty much do that. I'm not sure including the term
"PowerStatus" when the log shows you're modifying power_status.cc is an extra
benefit.

Granted, it isn't always obvious how to connect the filename/class name to
user-visible feature or UI. But if something breaks on chromeos only and it has
to do with power, settings, brightness, or the session length notifications then
it seems like the touched file list is a pretty good clue; also, if there's a
crash stack it lists file names.

https://codereview.chromium.org/2770953003/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/power/power_status.cc (right):

https://codereview.chromium.org/2770953003/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/power/power_status.cc:323: // Use ICON_BADGE_ALERT if
the battery is critically low and does not already
On 2017/03/22 23:23:07, tdanderson wrote:
> nit: "Use an alert badge"

Done.

https://codereview.chromium.org/2770953003/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/power/power_status.cc:323: // Use ICON_BADGE_ALERT if
the battery is critically low and does not already
On 2017/03/22 23:23:07, tdanderson wrote:
> nit: "Use an alert badge"

Done.

https://codereview.chromium.org/2770953003/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/power/power_status.cc:361: if (info.icon_badge) {
On 2017/03/22 23:23:07, tdanderson wrote:
> nit: remove {}

Done.

[Evan Stade, 2017-03-23 15:56:04]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-03-23 15:56:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org
Link to the patchset: https://codereview.chromium.org/2770953003/#ps20001
(title: "ta review + rebase")

[commit-bot: I haz the power, 2017-03-23 15:56:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 16:15:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 16:15:22]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Evan Stade, 2017-03-27 15:08:27]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2017-03-27 15:08:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 15:11:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 15:11:31]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Evan Stade, 2017-03-27 16:54:48]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-03-27 16:54:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org
Link to the patchset: https://codereview.chromium.org/2770953003/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-27 16:55:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 18:33:06]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490633688132320,
"parent_rev": "3321d7f0ab6782ed8e316e5b94b21aad2c77a603", "commit_rev":
"36cfbe932ed734d1935b8eeb9273aff1b80c598c"}

[commit-bot: I haz the power, 2017-03-27 18:38:46]

Description was changed from

==========
Remove some pre-md code and assets.

BUG=687816,686234,686335
==========

to

==========
Remove some pre-md code and assets.

BUG=687816,686234,686335

Review-Url: https://codereview.chromium.org/2770953003
Cr-Commit-Position: refs/heads/master@{#459837}
Committed:
https://chromium.googlesource.com/chromium/src/+/36cfbe932ed734d1935b8eeb9273...
==========

[commit-bot: I haz the power, 2017-03-27 18:38:48]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/36cfbe932ed734d1935b8eeb9273...

[findit-for-me, 2017-03-27 19:51:21]

Findit identified this CL at revision 459837 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[jwd, 2017-03-27 21:12:47]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2776973005/ by jwd@chromium.org.

The reason for reverting is: Causing failures on chromium.chromiumos/Linux
ChromiumOS Tests (dbg)(1)

BUG=705678.

[danakj, 2017-03-29 22:07:20]

Description was changed from

==========
Remove some pre-md code and assets.

BUG=687816,686234,686335

Review-Url: https://codereview.chromium.org/2770953003
Cr-Commit-Position: refs/heads/master@{#459837}
Committed:
https://chromium.googlesource.com/chromium/src/+/36cfbe932ed734d1935b8eeb9273...
==========

to

==========
Remove some pre-md code and assets.

BUG=687816,686234,686335

Review-Url: https://codereview.chromium.org/2770953003
Cr-Commit-Position: refs/heads/master@{#459837}
Committed:
https://chromium.googlesource.com/chromium/src/+/36cfbe932ed734d1935b8eeb9273...
==========

[danakj, 2017-03-29 22:08:01]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2017-03-29 22:08:02]

Hey terry, did this reland on another CL or is there another one I can watch
(I'm waiting to rebase on it)?

[danakj, 2017-03-29 22:08:28]

On 2017/03/29 22:08:02, danakj wrote:
> Hey terry, did this reland on another CL or is there another one I can watch
> (I'm waiting to rebase on it)?

Oops, or Evan :) I misread reviewer/author.

[Evan Stade, 2017-03-29 22:36:58]

On 2017/03/29 22:08:28, danakj wrote:
> On 2017/03/29 22:08:02, danakj wrote:
> > Hey terry, did this reland on another CL or is there another one I can watch
> > (I'm waiting to rebase on it)?
> 
> Oops, or Evan :) I misread reviewer/author.

It has relanded.

[danakj, 2017-03-29 22:38:25]

On Wed, Mar 29, 2017 at 6:36 PM, <estade@chromium.org> wrote:

> On 2017/03/29 22:08:28, danakj wrote:
> > On 2017/03/29 22:08:02, danakj wrote:
> > > Hey terry, did this reland on another CL or is there another one I can
> watch
> > > (I'm waiting to rebase on it)?
> >
> > Oops, or Evan :) I misread reviewer/author.
>
> It has relanded.
>

Cool, thanks!

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.