Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 2776973003: [Doodle] Move ttl clamping from fetcher to service (Closed)

Created:
3 years, 9 months ago by Marc Treib
Modified:
3 years, 9 months ago
Reviewers:
fhorschig
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Doodle] Move ttl clamping from fetcher to service This resolves a TODO in the code. BUG=690467 Review-Url: https://codereview.chromium.org/2776973003 Cr-Commit-Position: refs/heads/master@{#459764} Committed: https://chromium.googlesource.com/chromium/src/+/02ee8d6d2e8a9d81c7a18d93b1d944fc514da6f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -33 lines) Patch
M components/doodle/doodle_fetcher_impl.cc View 2 chunks +4 lines, -11 lines 0 comments Download
M components/doodle/doodle_fetcher_impl_unittest.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M components/doodle/doodle_service.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M components/doodle/doodle_service_unittest.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
Marc Treib
PTAL!
3 years, 9 months ago (2017-03-27 12:14:21 UTC) #3
fhorschig
Very lgtm, thanks!
3 years, 9 months ago (2017-03-27 12:19:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776973003/1
3 years, 9 months ago (2017-03-27 13:00:10 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 13:04:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/02ee8d6d2e8a9d81c7a18d93b1d9...

Powered by Google App Engine
This is Rietveld 408576698