Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: components/doodle/doodle_fetcher_impl_unittest.cc

Issue 2776973003: [Doodle] Move ttl clamping from fetcher to service (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/doodle/doodle_fetcher_impl.cc ('k') | components/doodle/doodle_service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/doodle/doodle_fetcher_impl.h" 5 #include "components/doodle/doodle_fetcher_impl.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
221 EXPECT_THAT(config.alt_text, Eq("Mouseover Text")); 221 EXPECT_THAT(config.alt_text, Eq("Mouseover Text"));
222 EXPECT_THAT(config.interactive_html, 222 EXPECT_THAT(config.interactive_html,
223 Eq("\u003cstyle\u003e\u003c/style\u003e")); 223 Eq("\u003cstyle\u003e\u003c/style\u003e"));
224 224
225 EXPECT_FALSE(config.large_cta_image.has_value()); 225 EXPECT_FALSE(config.large_cta_image.has_value());
226 EXPECT_FALSE(config.transparent_large_image.has_value()); 226 EXPECT_FALSE(config.transparent_large_image.has_value());
227 227
228 EXPECT_THAT(time_to_live, Eq(base::TimeDelta::FromMilliseconds(55000))); 228 EXPECT_THAT(time_to_live, Eq(base::TimeDelta::FromMilliseconds(55000)));
229 } 229 }
230 230
231 TEST_F(DoodleFetcherImplTest, DoodleExpiresWithinThirtyDaysForTooLargeTTL) {
232 base::MockCallback<DoodleFetcherImpl::FinishedCallback> callback;
233 doodle_fetcher()->FetchDoodle(callback.Get());
234
235 DoodleState state = DoodleState::NO_DOODLE;
236 base::TimeDelta time_to_live;
237 base::Optional<DoodleConfig> response;
238 EXPECT_CALL(callback, Run(_, _, _))
239 .WillOnce(DoAll(SaveArg<0>(&state), SaveArg<1>(&time_to_live),
240 SaveArg<2>(&response)));
241 RespondWithData(R"json({"ddljson": {
242 "time_to_live_ms":5184000000,
243 "large_image": {"url":"/logos/doodles/2015/some.gif"}
244 }})json"); // 60 days
245
246 EXPECT_THAT(state, Eq(DoodleState::AVAILABLE));
247 EXPECT_TRUE(response.has_value());
248 EXPECT_THAT(time_to_live,
249 Eq(base::TimeDelta::FromMilliseconds(30ul * 24 * 60 * 60 *
250 1000))); // 30 days
251 }
252
253 TEST_F(DoodleFetcherImplTest, DoodleExpiresImmediatelyWithNegativeTTL) { 231 TEST_F(DoodleFetcherImplTest, DoodleExpiresImmediatelyWithNegativeTTL) {
254 base::MockCallback<DoodleFetcherImpl::FinishedCallback> callback; 232 base::MockCallback<DoodleFetcherImpl::FinishedCallback> callback;
255 doodle_fetcher()->FetchDoodle(callback.Get()); 233 doodle_fetcher()->FetchDoodle(callback.Get());
256 234
257 DoodleState state = DoodleState::NO_DOODLE; 235 DoodleState state = DoodleState::NO_DOODLE;
258 base::TimeDelta time_to_live; 236 base::TimeDelta time_to_live;
259 base::Optional<DoodleConfig> response; 237 base::Optional<DoodleConfig> response;
260 EXPECT_CALL(callback, Run(_, _, _)) 238 EXPECT_CALL(callback, Run(_, _, _))
261 .WillOnce(DoAll(SaveArg<0>(&state), SaveArg<1>(&time_to_live), 239 .WillOnce(DoAll(SaveArg<0>(&state), SaveArg<1>(&time_to_live),
262 SaveArg<2>(&response))); 240 SaveArg<2>(&response)));
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
453 431
454 TEST_F(DoodleFetcherImplNoGrayBgTest, PassesNoGrayBgParam) { 432 TEST_F(DoodleFetcherImplNoGrayBgTest, PassesNoGrayBgParam) {
455 base::MockCallback<DoodleFetcherImpl::FinishedCallback> callback; 433 base::MockCallback<DoodleFetcherImpl::FinishedCallback> callback;
456 doodle_fetcher()->FetchDoodle(callback.Get()); 434 doodle_fetcher()->FetchDoodle(callback.Get());
457 435
458 EXPECT_THAT(GetRunningFetcher()->GetOriginalURL(), 436 EXPECT_THAT(GetRunningFetcher()->GetOriginalURL(),
459 Eq(Resolve(kDoodleConfigPathNoGrayBg))); 437 Eq(Resolve(kDoodleConfigPathNoGrayBg)));
460 } 438 }
461 439
462 } // namespace doodle 440 } // namespace doodle
OLDNEW
« no previous file with comments | « components/doodle/doodle_fetcher_impl.cc ('k') | components/doodle/doodle_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698