Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2776883003: DevTools: normalize medium icons (Closed)

Created:
3 years, 9 months ago by lushnikov
Modified:
3 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: normalize medium icons This patch normalizes sizes for mediumicons, making them all 16x16. This patch is only possible with https://crrev.com/2772153002/: it makes sure that icons have enough space around and thus could be set more width and height. BUG=700249 R=dgozman Review-Url: https://codereview.chromium.org/2776883003 Cr-Commit-Position: refs/heads/master@{#459914} Committed: https://chromium.googlesource.com/chromium/src/+/f7c841cfa3015088d90afdbb1fce08223105444d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -28 lines) Patch
M third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/computedStyleSidebarPane.css View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/elementsPanel.css View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/persistence/PersistenceUtils.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/sourcesSearch.css View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Icon.js View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/tabbedPane.css View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/toolbar.css View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
lushnikov
please, take a look
3 years, 9 months ago (2017-03-25 07:51:35 UTC) #1
dgozman
lgtm
3 years, 9 months ago (2017-03-25 15:48:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776883003/1
3 years, 9 months ago (2017-03-27 21:11:28 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 22:46:21 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f7c841cfa3015088d90afdbb1fce...

Powered by Google App Engine
This is Rietveld 408576698