Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2768923006: DevTools: define icon location with row and column (Closed)

Created:
3 years, 9 months ago by lushnikov
Modified:
3 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: define icon location with row and column This patch: - moves icons from {x, y, width, height} coordinates into {row, column} coordinates. - removes spritesheet image sizes from inspectorCommon.css. This turned out to be possible since icon's background/mask-image has default size of the image. This solves multiple issues: - it's easy to convert between icon coordinates and spritesheets (coordinate system is added to SVG files: http://imgur.com/a/rSLSN) - it discourages using non-standard icon sizes - resizing spritesheet is as easy as changing its size in inkscape BUG=700249

Patch Set 1 #

Patch Set 2 : add coordinates to svg files #

Messages

Total messages: 9 (7 generated)
lushnikov
please, take a look This is the last patch towards icons subsystem improvement.
3 years, 9 months ago (2017-03-25 09:38:03 UTC) #3
lushnikov
3 years, 9 months ago (2017-03-25 18:45:15 UTC) #9
Closing this patchset in favor of https://codereview.chromium.org/2776893002/

Powered by Google App Engine
This is Rietveld 408576698