Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2776243006: Fix ChromeBackgroundServiceWaiter timeout, and restart offline pages (Closed)

Created:
3 years, 8 months ago by Pete Williamson
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Fix ChromeBackgroundServiceWaiter timeout, and restart offline pages We had been using a 4 minute max timeout in ChromeBackgroundServcieWatier. However, the GCM NM docs state that we are only guaranteed 3 minutes. So, I'm backing off the 4 minute timeout to just under 3 minutes. Also, since I wrote the file, others have added a mechanism to restore tasks if Google Play Services (GPS) upgrades, I added a similar mechanism for OfflinePages. BUG=705584 Review-Url: https://codereview.chromium.org/2780643002 Cr-Commit-Position: refs/heads/master@{#460432} (cherry picked from commit bb5b80f0f2882522fb2ead659374aa05ac218c9f) Review-Url: https://codereview.chromium.org/2776243006 . Cr-Commit-Position: refs/branch-heads/3029@{#477} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/1e3f6951e12f953fb21ea932e7df0db8040457d8

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
Pete Williamson
3 years, 8 months ago (2017-03-29 18:10:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1e3f6951e12f953fb21ea932e7df0db8040457d8.

Powered by Google App Engine
This is Rietveld 408576698