Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Issue 2780643002: Fix ChromeBackgroundServiceWaiter timeout, and restart offline pages (Closed)

Created:
3 years, 8 months ago by Pete Williamson
Modified:
3 years, 8 months ago
Reviewers:
nyquist, fgorski
CC:
chromium-reviews, dewittj+watch_chromium.org, fgorski+watch_chromium.org, romax+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, agrieve+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ChromeBackgroundServiceWaiter timeout, and restart offline pages We had been using a 4 minute max timeout in ChromeBackgroundServcieWatier. However, the GCM NM docs state that we are only guaranteed 3 minutes. So, I'm backing off the 4 minute timeout to just under 3 minutes. Also, since I wrote the file, others have added a mechanism to restore tasks if Google Play Services (GPS) upgrades, I added a similar mechanism for OfflinePages. BUG=705584 Review-Url: https://codereview.chromium.org/2780643002 Cr-Commit-Position: refs/heads/master@{#460432} Committed: https://chromium.googlesource.com/chromium/src/+/bb5b80f0f2882522fb2ead659374aa05ac218c9f

Patch Set 1 #

Patch Set 2 : Fix unit test failure #

Messages

Total messages: 24 (16 generated)
Pete Williamson
3 years, 8 months ago (2017-03-27 20:21:48 UTC) #2
fgorski
lgtm, please add Tommy.
3 years, 8 months ago (2017-03-27 20:28:44 UTC) #3
Pete Williamson
+nyquist, please check changes to ChromeBackgroundService. Thanks!
3 years, 8 months ago (2017-03-27 20:31:40 UTC) #5
nyquist
lgtm
3 years, 8 months ago (2017-03-28 23:19:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780643002/20001
3 years, 8 months ago (2017-03-28 23:27:18 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder ...
3 years, 8 months ago (2017-03-29 02:17:46 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780643002/20001
3 years, 8 months ago (2017-03-29 17:09:40 UTC) #21
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 17:15:25 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bb5b80f0f2882522fb2ead659374...

Powered by Google App Engine
This is Rietveld 408576698