Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2776243005: Fix constants in constraints util tests. (Closed)

Created:
3 years, 8 months ago by Guido Urdaneta
Modified:
3 years, 8 months ago
Reviewers:
hbos_chromium
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, avayvod+watch_chromium.org, darin-cc_chromium.org, jasonroberts+watch_google.com, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix constants in constraints util tests. Add the const qualifier to many constants that should have it. Replace int with double in some cases. BUG=657733 Review-Url: https://codereview.chromium.org/2776243005 Cr-Commit-Position: refs/heads/master@{#460340} Committed: https://chromium.googlesource.com/chromium/src/+/7d554df21b4c8f07f93e9cd2552de2ac8abf852b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -28 lines) Patch
M content/renderer/media/media_stream_constraints_util_sets_unittest.cc View 4 chunks +17 lines, -17 lines 0 comments Download
M content/renderer/media/media_stream_constraints_util_video_content_unittest.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M content/renderer/media/media_stream_constraints_util_video_device_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
Guido Urdaneta
Hi, PTAL
3 years, 8 months ago (2017-03-29 09:06:44 UTC) #4
hbos_chromium
lgtm
3 years, 8 months ago (2017-03-29 09:58:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776243005/20001
3 years, 8 months ago (2017-03-29 09:58:47 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 10:19:26 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7d554df21b4c8f07f93e9cd2552d...

Powered by Google App Engine
This is Rietveld 408576698