Fix constants in constraints util tests.

content/renderer/media/media_stream_constraints_util_sets_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/media_stream_constraints_util_sets.h"
 
 #include <cmath>
 #include <string>
 #include <vector>
 
@@ skipping 356 matching lines @@
   set = ResolutionSet(1, 1, 1, 1, 0.5, 0.5);
   EXPECT_TRUE(set.IsEmpty());
   EXPECT_TRUE(set.IsAspectRatioEmpty());
   EXPECT_FALSE(set.ContainsPoint(0, 0));
   EXPECT_FALSE(set.ContainsPoint(1, 1));
   EXPECT_FALSE(set.ContainsPoint(1, 0));
   EXPECT_FALSE(set.ContainsPoint(0, 1));
 }
 
 TEST_F(MediaStreamConstraintsUtilSetsTest, ResolutionBoxEmptiness) {
-  int kMin = 100;
-  int kMax = 200;
+  const int kMin = 100;
+  const int kMax = 200;
   // Max aspect ratio below box.
   ResolutionSet set(kMin, kMax, kMin, kMax, 0.4, 0.4);
   EXPECT_TRUE(set.IsEmpty());
   EXPECT_TRUE(set.IsAspectRatioEmpty());
 
   // Min aspect ratio above box.
   set = ResolutionSet(kMin, kMax, kMin, kMax, 3.0, HUGE_VAL);
   EXPECT_TRUE(set.IsEmpty());
   EXPECT_TRUE(set.IsAspectRatioEmpty());
 
@@ skipping 178 matching lines @@
   EXPECT_EQ(P(20, 10), set.ClosestPointTo(P(20, 9)));
   EXPECT_EQ(P(100, 50), set.ClosestPointTo(P(101, 50)));
   EXPECT_EQ(P(100, 100), set.ClosestPointTo(P(101, 101)));
   EXPECT_EQ(P(100 / 1.5, 100), set.ClosestPointTo(P(100 / 1.5, 101)));
   EXPECT_EQ(P(10, 15), set.ClosestPointTo(P(9, 15)));
 }
 
 TEST_F(MediaStreamConstraintsUtilSetsTest, ResolutionIdealIntersects) {
   ResolutionSet set(100, 1000, 100, 1000, 0.5, 2.0);
 
-  int kIdealHeight = 500;
-  int kIdealWidth = 1000;
-  double kIdealAspectRatio = 1.5;
+  const int kIdealHeight = 500;
+  const int kIdealWidth = 1000;
+  const double kIdealAspectRatio = 1.5;
 
   // Ideal height.
   {
     factory_.Reset();
     factory_.basic().height.setIdeal(kIdealHeight);
     Point point = set.SelectClosestPointToIdeal(
         factory_.CreateWebMediaConstraints().basic());
     EXPECT_POINT_EQ(
         Point(kIdealHeight,
               kIdealHeight * MediaStreamVideoSource::kDefaultAspectRatio),
@@ skipping 64 matching lines @@
         factory_.CreateWebMediaConstraints().basic());
     // Ideal aspect ratio should be ignored.
     EXPECT_POINT_EQ(Point(kIdealHeight, kIdealWidth), point);
   }
 }
 
 TEST_F(MediaStreamConstraintsUtilSetsTest, ResolutionIdealOutsideSinglePoint) {
   // This set is a triangle with vertices (100,100), (1000,100) and (1000,1000).
   ResolutionSet set(100, 1000, 100, 1000, 0.0, 1.0);
 
-  int kIdealHeight = 50;
-  int kIdealWidth = 1100;
-  double kIdealAspectRatio = 0.09;
-  Point kVertex1(100, 100);
-  Point kVertex2(1000, 100);
-  Point kVertex3(1000, 1000);
+  const int kIdealHeight = 50;
+  const int kIdealWidth = 1100;
+  const double kIdealAspectRatio = 0.09;
+  const Point kVertex1(100, 100);
+  const Point kVertex2(1000, 100);
+  const Point kVertex3(1000, 1000);
 
   // Ideal height.
   {
     factory_.Reset();
     factory_.basic().height.setIdeal(kIdealHeight);
     Point point = set.SelectClosestPointToIdeal(
         factory_.CreateWebMediaConstraints().basic());
     EXPECT_POINT_EQ(kVertex1, point);
   }
 
@@ skipping 62 matching lines @@
     Point expected = set.ClosestPointTo(Point(kIdealHeight, kIdealWidth));
     EXPECT_POINT_EQ(expected, point);
   }
 }
 
 TEST_F(MediaStreamConstraintsUtilSetsTest,
        ResolutionIdealOutsideMultiplePoints) {
   // This set is a triangle with vertices (100,100), (1000,100) and (1000,1000).
   ResolutionSet set(100, 1000, 100, 1000, 0.0, 1.0);
 
-  int kIdealHeight = 1100;
-  int kIdealWidth = 50;
-  double kIdealAspectRatio = 11.0;
-  Point kVertex1(100, 100);
-  Point kVertex2(1000, 100);
-  Point kVertex3(1000, 1000);
+  const int kIdealHeight = 1100;
+  const int kIdealWidth = 50;
+  const double kIdealAspectRatio = 11.0;
+  const Point kVertex1(100, 100);
+  const Point kVertex2(1000, 100);
+  const Point kVertex3(1000, 1000);
 
   // Ideal height.
   {
     factory_.Reset();
     factory_.basic().height.setIdeal(kIdealHeight);
     Point point = set.SelectClosestPointToIdeal(
         factory_.CreateWebMediaConstraints().basic());
     // Parallel to the side between kVertex2 and kVertex3. Point closest to
     // default aspect ratio is kVertex3.
     EXPECT_POINT_EQ(kVertex3, point);
@@ skipping 504 matching lines @@
   EXPECT_TRUE(intersection.Contains(true));
   EXPECT_TRUE(intersection.Contains(true));
 
   // Empty intersection.
   set = BoolSet({true});
   intersection = set.Intersection(BoolSet({false}));
   EXPECT_TRUE(intersection.IsEmpty());
 }
 
 }  // namespace content