Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2776033002: blink_gc_plugin: retire warn-stack-allocated-trace-method option. (Closed)

Created:
3 years, 9 months ago by sof
Modified:
3 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

blink_gc_plugin: retire warn-stack-allocated-trace-method option. As a final(!) step in phasing in the check over trace() methods inside of STACK_ALLOCATED() classes, remove the detection of the warning option. It's always on. R= BUG=689874 Review-Url: https://codereview.chromium.org/2776033002 Cr-Commit-Position: refs/heads/master@{#459677} Committed: https://chromium.googlesource.com/chromium/src/+/5388a131f6f63314ef21f730f3e6151c6ff8db56

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
D tools/clang/blink_gc_plugin/tests/legacy_naming/stack_allocated.flags View 1 chunk +0 lines, -1 line 0 comments Download
D tools/clang/blink_gc_plugin/tests/stack_allocated.flags View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
sof
please take a look. (will land this some time after https://codereview.chromium.org/2776023002/.)
3 years, 9 months ago (2017-03-26 06:36:14 UTC) #6
Nico
lgtm
3 years, 9 months ago (2017-03-26 13:45:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776033002/1
3 years, 9 months ago (2017-03-26 17:33:49 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-26 17:38:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5388a131f6f63314ef21f730f3e6...

Powered by Google App Engine
This is Rietveld 408576698