tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp - Issue 2776033002: blink_gc_plugin: retire warn-stack-allocated-trace-method option.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp

Issue 2776033002: blink_gc_plugin: retire warn-stack-allocated-trace-method option. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp

diff --git a/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp b/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp

index 43b064ccdcf3f2068f7633de2aa1c51212cb0af8..d263a8cc5eea20fa9bae021db02fe247ecf004b6 100644

--- a/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp

+++ b/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp

@@ -33,10 +33,6 @@ class BlinkGCPluginAction : public PluginASTAction {

for (const auto& arg : args) {

if (arg == "dump-graph") {

options_.dump_graph = true;

- } else if (arg == "warn-stack-allocated-trace-method") {

- // TODO(sof): after next roll, remove this option to round out

- // crbug.com/689874

- continue;

} else if (arg == "warn-unneeded-finalizer") {

options_.warn_unneeded_finalizer = true;

} else if (arg == "use-chromium-style-naming") {

« no previous file with comments | « no previous file | tools/clang/blink_gc_plugin/tests/legacy_naming/stack_allocated.flags » ('j') | no next file with comments »