Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2776023002: Remove no-op blink-gc-plugin argument. (Closed)

Created:
3 years, 9 months ago by sof
Modified:
3 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove no-op blink-gc-plugin argument. Following the clang roll in r455977, the clang blink_gc_plugin always warns of STACK_ALLOCATED() classes having redundant trace() methods; drop using the gc-plugin no-op option. R= BUG=689874 Review-Url: https://codereview.chromium.org/2776023002 Cr-Commit-Position: refs/heads/master@{#459676} Committed: https://chromium.googlesource.com/chromium/src/+/67512fae29e6cdb8ef5ffaee2fa42ccef4902b34

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M third_party/WebKit/Source/BUILD.gn View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
sof
please take a look. The last roll ae4a9e6 passed me by, thanks for doing that; ...
3 years, 9 months ago (2017-03-26 06:33:04 UTC) #6
Nico
lgtm
3 years, 9 months ago (2017-03-26 13:36:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776023002/1
3 years, 9 months ago (2017-03-26 13:36:38 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-26 16:48:55 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/67512fae29e6cdb8ef5ffaee2fa4...

Powered by Google App Engine
This is Rietveld 408576698