Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Side by Side Diff: third_party/WebKit/Source/BUILD.gn

Issue 2776023002: Remove no-op blink-gc-plugin argument. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("config.gni") 5 import("config.gni")
6 if (is_clang) { 6 if (is_clang) {
7 import("//build/config/clang/clang.gni") 7 import("//build/config/clang/clang.gni")
8 } 8 }
9 9
10 visibility = [ "//third_party/WebKit/*" ] 10 visibility = [ "//third_party/WebKit/*" ]
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 ] 151 ]
152 } 152 }
153 if (blink_gc_plugin_option_use_chromium_style_naming) { 153 if (blink_gc_plugin_option_use_chromium_style_naming) {
154 cflags += [ 154 cflags += [
155 "-Xclang", 155 "-Xclang",
156 "-plugin-arg-blink-gc-plugin", 156 "-plugin-arg-blink-gc-plugin",
157 "-Xclang", 157 "-Xclang",
158 "use-chromium-style-naming", 158 "use-chromium-style-naming",
159 ] 159 ]
160 } 160 }
161
162 # TODO(https://crbug.com/689864): remove once the GC plugin has been rolled
163 # with this warning default enabled.
164 cflags += [
165 "-Xclang",
166 "-plugin-arg-blink-gc-plugin",
167 "-Xclang",
168 "warn-stack-allocated-trace-method",
169 ]
170 } 161 }
171 } 162 }
172 163
173 # The follow configs apply to all targets except for unit tests, which rely on 164 # The follow configs apply to all targets except for unit tests, which rely on
174 # static initializers. 165 # static initializers.
175 config("non_test_config") { 166 config("non_test_config") {
176 cflags = [] 167 cflags = []
177 168
178 if (is_clang) { 169 if (is_clang) {
179 cflags += [ "-Wglobal-constructors" ] 170 cflags += [ "-Wglobal-constructors" ]
180 } 171 }
181 } 172 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698