Promotes more accessors from WmShell to Shell

Promotes more accessors from WmShell to Shell

BUG=687660
TEST=covered by tests
R=msw@chromium.org,wez@chromium.org, reveman@chromium.org
TBR=reveman@chromium.org

Review-Url: https://codereview.chromium.org/2775973002
Cr-Commit-Position: refs/heads/master@{#459692}
Committed: https://chromium.googlesource.com/chromium/src/+/5b45ed88b90be5c3499158e199a2b89148afb35e

[sky, 2017-03-24 22:10:34]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 22:10:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2017-03-24 22:46:17]

nice; lgtm with a couple nits

https://codereview.chromium.org/2775973002/diff/1/chrome/browser/ui/ash/multi...
File chrome/browser/ui/ash/multi_user/user_switch_util_unittest.cc (right):

https://codereview.chromium.org/2775973002/diff/1/chrome/browser/ui/ash/multi...
chrome/browser/ui/ash/multi_user/user_switch_util_unittest.cc:5: #include
"chrome/browser/ui/ash/multi_user/user_switch_util.h"
nit: blank line after

https://codereview.chromium.org/2775973002/diff/1/chrome/browser/ui/ash/multi...
chrome/browser/ui/ash/multi_user/user_switch_util_unittest.cc:85: const
WindowSelectorController* window_selector_controller() const {
optional nit: inline these accessors (just two uses below...)

[commit-bot: I haz the power, 2017-03-24 22:53:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 22:53:12]

Dry run: This issue passed the CQ dry run.

[sky, 2017-03-24 23:22:30]

https://codereview.chromium.org/2775973002/diff/1/chrome/browser/ui/ash/multi...
File chrome/browser/ui/ash/multi_user/user_switch_util_unittest.cc (right):

https://codereview.chromium.org/2775973002/diff/1/chrome/browser/ui/ash/multi...
chrome/browser/ui/ash/multi_user/user_switch_util_unittest.cc:5: #include
"chrome/browser/ui/ash/multi_user/user_switch_util.h"
On 2017/03/24 22:46:17, msw wrote:
> nit: blank line after

git cl format does this, but didn't add the newline. Will have to file a bug on
it.

https://codereview.chromium.org/2775973002/diff/1/chrome/browser/ui/ash/multi...
chrome/browser/ui/ash/multi_user/user_switch_util_unittest.cc:85: const
WindowSelectorController* window_selector_controller() const {
On 2017/03/24 22:46:17, msw wrote:
> optional nit: inline these accessors (just two uses below...)

Done.

[sky, 2017-03-24 23:22:44]

The CQ bit was checked by sky@chromium.org

[sky, 2017-03-24 23:22:44]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2775973002/#ps20001
(title: "feedback")

[commit-bot: I haz the power, 2017-03-24 23:23:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 23:36:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 23:36:50]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sky, 2017-03-26 15:22:09]

Description was changed from

==========
Promotes more accessors from WmShell to Shell

BUG=687660
TEST=covered by tests
R=msw@chromium.org
==========

to

==========
Promotes more accessors from WmShell to Shell

BUG=687660
TEST=covered by tests
R=msw@chromium.org,wez@chromium.org
==========

[sky, 2017-03-26 15:22:09]

sky@chromium.org changed reviewers:
+ wez@chromium.org

[sky, 2017-03-26 15:22:33]

+wez for remoting change, and TBRing trivial change

[sky, 2017-03-26 15:22:42]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-03-26 15:22:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-26 15:30:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-26 15:30:25]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Wez, 2017-03-27 00:24:29]

The CQ bit was checked by wez@chromium.org

[Wez, 2017-03-27 00:24:30]

lgtm

[commit-bot: I haz the power, 2017-03-27 00:24:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 00:31:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 00:31:56]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sky, 2017-03-27 02:48:32]

Description was changed from

==========
Promotes more accessors from WmShell to Shell

BUG=687660
TEST=covered by tests
R=msw@chromium.org,wez@chromium.org
==========

to

==========
Promotes more accessors from WmShell to Shell

BUG=687660
TEST=covered by tests
R=msw@chromium.org,wez@chromium.org, reveman@chromium.org
TBR=reveman@chromium.org
==========

[sky, 2017-03-27 02:49:06]

+reveman for change, and TBR for trivial name change.

[sky, 2017-03-27 02:49:22]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-03-27 02:49:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 02:54:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490582962402870,
"parent_rev": "16dbfc61f5335aef68b05282eba042632b2ea9a8", "commit_rev":
"5b45ed88b90be5c3499158e199a2b89148afb35e"}

[commit-bot: I haz the power, 2017-03-27 02:55:11]

Description was changed from

==========
Promotes more accessors from WmShell to Shell

BUG=687660
TEST=covered by tests
R=msw@chromium.org,wez@chromium.org, reveman@chromium.org
TBR=reveman@chromium.org
==========

to

==========
Promotes more accessors from WmShell to Shell

BUG=687660
TEST=covered by tests
R=msw@chromium.org,wez@chromium.org, reveman@chromium.org
TBR=reveman@chromium.org

Review-Url: https://codereview.chromium.org/2775973002
Cr-Commit-Position: refs/heads/master@{#459692}
Committed:
https://chromium.googlesource.com/chromium/src/+/5b45ed88b90be5c3499158e199a2...
==========

[commit-bot: I haz the power, 2017-03-27 02:55:15]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5b45ed88b90be5c3499158e199a2...