Instrumented libraries: Remove dependence on GYP_DEFINES

third_party/instrumented_libraries/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/sanitizers/sanitizers.gni")
 import("//build/toolchain/goma.gni")
 
 declare_args() {
   # The platform on which the instrumented libraries are being built.
   instrumented_libraries_platform = "trusty"
@@ skipping 39 matching lines @@
   }
 
   if (is_msan) {
     if (msan_track_origins == 0) {
       archive_prefix = "msan-no-origins"
     } else if (msan_track_origins == 2) {
       archive_prefix = "msan-chained-origins"
     }
   }
 
-  # TODO(GYP): scripts/download_binaries.py uses GYP_DEFINES to decide whether
-  # to download the archives extracted here.
+  action("download_prebuilt_instrumented_libraries") {
+    tarfile_name = "$archive_prefix-$instrumented_libraries_platform.tgz"
+    shafile = "binaries/$tarfile_name.sha1"
+    tarfile = "$target_out_dir/$tarfile_name"

[Michael Achenbach, 2017/03/28 07:55:05]

Please note that now different out directories don't share the downloaded
binaries anymore. Before they would have. Not sure if that's relevant for those,
but I believe that for something like pre-built clang, we couldn't use this
logic.

+    inputs = [ shafile ]
+    outputs = [ tarfile ]
+    script = "scripts/download_binaries.py"
+    args = [ rebase_path(shafile), rebase_path(tarfile) ]
+  }
+
   # Note: This requires a clobber whenever Ubuntu version changes.
   action("extract_prebuilt_instrumented_libraries") {
+    deps = [ ":download_prebuilt_instrumented_libraries" ]
     visibility = [ ":prebuilt" ]
     script = "scripts/unpack_binaries.py"
     depfile = "$target_out_dir/$archive_prefix.d"
+    tarfile = get_target_outputs(":download_prebuilt_instrumented_libraries")
     args = [
-      archive_prefix,
-      rebase_path("binaries"),
+      rebase_path(tarfile[0]),
+      rebase_path("$target_out_dir/$archive_prefix.txt"),
       rebase_path(root_out_dir + "/instrumented_libraries_prebuilt"),
-      rebase_path(target_out_dir, root_out_dir),
     ]
     outputs = [
       "$target_out_dir/$archive_prefix.txt",
     ]
     data = [
       "$root_out_dir/instrumented_libraries_prebuilt/",
     ]
   }
 
   config("prebuilt_ldflags") {
@@ skipping 722 matching lines @@
       "--disable-gudev",
     ]
     pre_build = "scripts/pre-build/udev.sh"
   }
 
   instrumented_library("zlib1g") {
     # --disable-static is not supported
     patch = "patches/zlib1g.diff"
   }
 }