Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2775703002: [Media>UI] Allow the notification info to be updated before playback service is created (Closed)

Created:
3 years, 9 months ago by Zhiqiang Zhang (Slow)
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Media>UI] Allow the notification info to be updated before playback service is created This CL fixes an issue that when a playback service is pending for start, and the playback gets paused, the MediaNotificationInfo is not updated so that when the service gets started, we are still seeing info with "playing" state. BUG=704567 Review-Url: https://codereview.chromium.org/2769213002 Cr-Commit-Position: refs/heads/master@{#459139} (cherry picked from commit 54c2facf2675be87fcbe39b74550b87fc0df08d8) Review-Url: https://codereview.chromium.org/2775703002 . Cr-Commit-Position: refs/branch-heads/3029@{#390} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/bdb151d3a1eb329db72dfd8fa3f56374a3909488

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Zhiqiang Zhang (Slow)
3 years, 9 months ago (2017-03-23 18:59:15 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
bdb151d3a1eb329db72dfd8fa3f56374a3909488.

Powered by Google App Engine
This is Rietveld 408576698