[Media>UI] Allow the notification info to be updated before playback service is created

[Media>UI] Allow the notification info to be updated before playback service is created

This CL fixes an issue that when a playback service is pending for start, and
the playback gets paused, the MediaNotificationInfo is not updated so that when
the service gets started, we are still seeing info with "playing" state.

BUG=704567
Review-Url: https://codereview.chromium.org/2769213002
Cr-Commit-Position: refs/heads/master@{#459139}
Committed: https://chromium.googlesource.com/chromium/src/+/54c2facf2675be87fcbe39b74550b87fc0df08d8

[Zhiqiang Zhang (Slow), 2017-03-23 15:50:50]

zqzhang@chromium.org changed reviewers:
+ avayvod@chromium.org

[Zhiqiang Zhang (Slow), 2017-03-23 15:50:50]

PTAL

[whywhat, 2017-03-23 16:27:39]

lgtm

https://codereview.chromium.org/2769213002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
(right):

https://codereview.chromium.org/2769213002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java:670:
if (mService == null && mediaNotificationInfo.isPaused) return;
But we just added this line this month!
Hopefully some logic above that checks for notification info equality won't
cause some regression because of this?

[Zhiqiang Zhang (Slow), 2017-03-23 17:07:52]

The CQ bit was checked by zqzhang@chromium.org

[Zhiqiang Zhang (Slow), 2017-03-23 17:07:52]

https://codereview.chromium.org/2769213002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
(right):

https://codereview.chromium.org/2769213002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java:670:
if (mService == null && mediaNotificationInfo.isPaused) return;
On 2017/03/23 at 16:27:39, whywhat wrote:
> But we just added this line this month!

That's why we need more tests :)

> Hopefully some logic above that checks for notification info equality won't
cause some regression because of this?

No, it won't. We always update the notification info for the same tabId.

[commit-bot: I haz the power, 2017-03-23 17:08:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 18:00:07]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490288872144020, "parent_rev":
"cc185fb06a698256572d717750923a2588928519", "commit_rev":
"54c2facf2675be87fcbe39b74550b87fc0df08d8"}

[commit-bot: I haz the power, 2017-03-23 18:00:55]

Description was changed from

==========
[Media>UI] Allow the notification info to be updated before playback service is
created

This CL fixes an issue that when a playback service is pending for start, and
the playback gets paused, the MediaNotificationInfo is not updated so that when
the service gets started, we are still seeing info with "playing" state.

BUG=704567
==========

to

==========
[Media>UI] Allow the notification info to be updated before playback service is
created

This CL fixes an issue that when a playback service is pending for start, and
the playback gets paused, the MediaNotificationInfo is not updated so that when
the service gets started, we are still seeing info with "playing" state.

BUG=704567

Review-Url: https://codereview.chromium.org/2769213002
Cr-Commit-Position: refs/heads/master@{#459139}
Committed:
https://chromium.googlesource.com/chromium/src/+/54c2facf2675be87fcbe39b74550...
==========

[commit-bot: I haz the power, 2017-03-23 18:00:56]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/54c2facf2675be87fcbe39b74550...