Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2775693002: Revert of Set default document urls to 'about:blank'. (Closed)

Created:
3 years, 9 months ago by Mike Wittman
Modified:
3 years, 9 months ago
Reviewers:
tkent, MartinRogalla
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Set default document urls to 'about:blank'. (patchset #4 id:60001 of https://codereview.chromium.org/2754933004/ ) Reason for revert: Appears to be causing failures on WebKit Mac10.12: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.12/builds/583 01:50:58.061 5302 worker/7 external/wpt/dom/interfaces.html output stderr lines: 01:50:58.061 5302 CONSOLE MESSAGE: line 251: callback not yet supported 01:50:58.082 5261 [18796/51893] external/wpt/dom/interfaces.html failed unexpectedly (text diff) 01:50:58.081 5302 worker/7 external/wpt/dom/interfaces.html failed: Original issue's description: > Set default document urls to 'about:blank'. > > The patch ensures that the document urls are set to 'about:blank', as is > specified in [1], if a url has not been specified. It fixes the tests in > [2] and [3]. > > The functionality is implemented by binding the document urls to > 'about:blank' if m_url is empty. To achieve this behavior the > Document::urlForBinding() function was added. The choice for a binding > was made rather than not using an intial value of 'about:blank' for the > document urls, as other parts of the code rely on the document urls > initially being empty. > > More details regarding the binding can be found under: > https://codereview.chromium.org/2749803003/#msg37 > > [1] https://dom.spec.whatwg.org/#interface-document > [2] http://w3c-test.org/dom/nodes/DOMImplementation-createDocument.html > [3] http://w3c-test.org/dom/nodes/DOMImplementation-createHTMLDocument.html > > BUG=563986 > > Review-Url: https://codereview.chromium.org/2754933004 > Cr-Commit-Position: refs/heads/master@{#459019} > Committed: https://chromium.googlesource.com/chromium/src/+/45009c8984881526e99cdb26a752a3acd29a0b60 TBR=tkent@chromium.org,martin@martinrogalla.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=563986 Review-Url: https://codereview.chromium.org/2775693002 Cr-Commit-Position: refs/heads/master@{#459153} Committed: https://chromium.googlesource.com/chromium/src/+/84834d7d0a7444ae10fb7c49161e1f825558c3ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1496 lines, -126 lines) Patch
A third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/documentgetdocumenturi02.js View 1 chunk +112 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/documentgetdocumenturi02.xhtml View 1 chunk +73 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/documentgetdocumenturi03.js View 1 chunk +118 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/documentgetdocumenturi03.xhtml View 1 chunk +73 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/documentgetdocumenturi03-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/documentsetdocumenturi03.js View 1 chunk +117 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/documentsetdocumenturi03.xhtml View 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/documentsetdocumenturi03-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/nodegetbaseuri02.js View 1 chunk +119 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/nodegetbaseuri02.xhtml View 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/nodegetbaseuri02-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt View 5 chunks +6 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/dom/nodes/DOMImplementation-createDocument-expected.txt View 6 chunks +91 lines, -91 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/dom/nodes/DOMImplementation-createHTMLDocument-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Node-cloneNode-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Node-properties-expected.txt View 1 chunk +703 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/document-attribute-js-null.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/document-attribute-js-null-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.11/external/wpt/dom/interfaces-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-retina/external/wpt/dom/interfaces-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/external/wpt/dom/interfaces-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Mike Wittman
Created Revert of Set default document urls to 'about:blank'.
3 years, 9 months ago (2017-03-23 18:28:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775693002/1
3 years, 9 months ago (2017-03-23 18:29:03 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/84834d7d0a7444ae10fb7c49161e1f825558c3ac
3 years, 9 months ago (2017-03-23 18:31:33 UTC) #6
tkent
3 years, 9 months ago (2017-03-23 22:35:30 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698