The CQ bit was checked by wittman@chromium.org
Created Revert of Set default document urls to 'about:blank'.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1490293707800250, "parent_rev": "2991103274c1a534ab244946305b2138b6d5b353", "commit_rev": "84834d7d0a7444ae10fb7c49161e1f825558c3ac"}
Description was changed from ========== Revert of Set default document urls to 'about:blank'. (patchset #4 id:60001 of https://codereview.chromium.org/2754933004/ ) Reason for revert: Appears to be causing failures on WebKit Mac10.12: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac1... 01:50:58.061 5302 worker/7 external/wpt/dom/interfaces.html output stderr lines: 01:50:58.061 5302 CONSOLE MESSAGE: line 251: callback not yet supported 01:50:58.082 5261 [18796/51893] external/wpt/dom/interfaces.html failed unexpectedly (text diff) 01:50:58.081 5302 worker/7 external/wpt/dom/interfaces.html failed: Original issue's description: > Set default document urls to 'about:blank'. > > The patch ensures that the document urls are set to 'about:blank', as is > specified in [1], if a url has not been specified. It fixes the tests in > [2] and [3]. > > The functionality is implemented by binding the document urls to > 'about:blank' if m_url is empty. To achieve this behavior the > Document::urlForBinding() function was added. The choice for a binding > was made rather than not using an intial value of 'about:blank' for the > document urls, as other parts of the code rely on the document urls > initially being empty. > > More details regarding the binding can be found under: > https://codereview.chromium.org/2749803003/#msg37 > > [1] https://dom.spec.whatwg.org/#interface-document > [2] http://w3c-test.org/dom/nodes/DOMImplementation-createDocument.html > [3] http://w3c-test.org/dom/nodes/DOMImplementation-createHTMLDocument.html > > BUG=563986 > > Review-Url: https://codereview.chromium.org/2754933004 > Cr-Commit-Position: refs/heads/master@{#459019} > Committed: https://chromium.googlesource.com/chromium/src/+/45009c8984881526e99cdb26a752... TBR=tkent@chromium.org,martin@martinrogalla.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=563986 ========== to ========== Revert of Set default document urls to 'about:blank'. (patchset #4 id:60001 of https://codereview.chromium.org/2754933004/ ) Reason for revert: Appears to be causing failures on WebKit Mac10.12: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac1... 01:50:58.061 5302 worker/7 external/wpt/dom/interfaces.html output stderr lines: 01:50:58.061 5302 CONSOLE MESSAGE: line 251: callback not yet supported 01:50:58.082 5261 [18796/51893] external/wpt/dom/interfaces.html failed unexpectedly (text diff) 01:50:58.081 5302 worker/7 external/wpt/dom/interfaces.html failed: Original issue's description: > Set default document urls to 'about:blank'. > > The patch ensures that the document urls are set to 'about:blank', as is > specified in [1], if a url has not been specified. It fixes the tests in > [2] and [3]. > > The functionality is implemented by binding the document urls to > 'about:blank' if m_url is empty. To achieve this behavior the > Document::urlForBinding() function was added. The choice for a binding > was made rather than not using an intial value of 'about:blank' for the > document urls, as other parts of the code rely on the document urls > initially being empty. > > More details regarding the binding can be found under: > https://codereview.chromium.org/2749803003/#msg37 > > [1] https://dom.spec.whatwg.org/#interface-document > [2] http://w3c-test.org/dom/nodes/DOMImplementation-createDocument.html > [3] http://w3c-test.org/dom/nodes/DOMImplementation-createHTMLDocument.html > > BUG=563986 > > Review-Url: https://codereview.chromium.org/2754933004 > Cr-Commit-Position: refs/heads/master@{#459019} > Committed: https://chromium.googlesource.com/chromium/src/+/45009c8984881526e99cdb26a752... TBR=tkent@chromium.org,martin@martinrogalla.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=563986 Review-Url: https://codereview.chromium.org/2775693002 Cr-Commit-Position: refs/heads/master@{#459153} Committed: https://chromium.googlesource.com/chromium/src/+/84834d7d0a7444ae10fb7c49161e... ==========
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/84834d7d0a7444ae10fb7c49161e...
lgtm