Initialize document m_URL, m_baseURL to blankURL.

Initialize document m_URL & m_baseURL to blankURL.

This patch will ensure that m_URL and m_baseURL are initialized to
blankURL (about:blank) as is specified in [1]. This patch fixes the
tests in [2] and [3].

[1] https://dom.spec.whatwg.org/#interface-document
[2] http://w3c-test.org/dom/nodes/DOMImplementation-createDocument.html
[3] http://w3c-test.org/dom/nodes/DOMImplementation-createHTMLDocument.html

BUG=563986
Review-Url: https://codereview.chromium.org/2749803003
Cr-Commit-Position: refs/heads/master@{#457347}
Committed: https://chromium.googlesource.com/chromium/src/+/9168f165fe92e37664a5e39fef987f0e3ad72a62

[MartinRogalla, 2017-03-14 22:37:35]

Description was changed from

==========
Initialize document m_URL & m_baseURL to blankURL.

This patch will ensure that m_URL and m_baseURL are initialized to
blankURL (about:blank) as is specified in [1]. This patch fixes the
tests in [2] and [3].

[1] https://dom.spec.whatwg.org/#interface-document
[2] http://w3c-test.org/dom/nodes/DOMImplementation-createDocument.html
[3] http://w3c-test.org/dom/nodes/DOMImplementation-createHTMLDocument.html

BUG=563986
==========

to

==========
Initialize document m_URL & m_baseURL to blankURL.

This patch will ensure that m_URL and m_baseURL are initialized to
blankURL (about:blank) as is specified in [1]. This patch fixes the
tests in [2] and [3].

[1] https://dom.spec.whatwg.org/#interface-document
[2] http://w3c-test.org/dom/nodes/DOMImplementation-createDocument.html
[3] http://w3c-test.org/dom/nodes/DOMImplementation-createHTMLDocument.html

BUG=563986
==========

[MartinRogalla, 2017-03-14 22:37:48]

martin@martinrogalla.com changed reviewers:
+ tkent@chromium.org

[MartinRogalla, 2017-03-14 22:42:46]

The CQ bit was checked by martin@martinrogalla.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 22:43:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 22:44:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 22:44:01]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[tkent, 2017-03-14 22:56:29]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 22:57:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 00:34:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 00:34:03]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tkent, 2017-03-15 00:43:45]

https://storage.googleapis.com/chromium-layout-test-archives/mac_chromium_rel...

As for dom/lagecy_dom_conformance/, if Firefox fails with them, let's remove the
tests.
As for fast/dom/document-attribute-js-null.html and
fast/dom/location-new-window-no-crash.html, it seems we need to update the tests
for the new behavior.

[MartinRogalla, 2017-03-15 01:08:21]

On 2017/03/15 00:43:45, tkent wrote:
>
https://storage.googleapis.com/chromium-layout-test-archives/mac_chromium_rel...
> 
> As for dom/lagecy_dom_conformance/, if Firefox fails with them, let's remove
the
> tests.
> As for fast/dom/document-attribute-js-null.html and
> fast/dom/location-new-window-no-crash.html, it seems we need to update the
tests
> for the new behavior.

I fixed all the tests except for "fast/dom/location-new-window-no-crash.html" as
I'm unsure if the behavior with the has "h" is correct. Instead of simply
changing the test, I would like to double check with you that indeed it's
behaving correctly.

[MartinRogalla, 2017-03-15 01:26:30]

On 2017/03/15 01:08:21, MartinRogalla wrote:
> On 2017/03/15 00:43:45, tkent wrote:
> >
>
https://storage.googleapis.com/chromium-layout-test-archives/mac_chromium_rel...
> > 
> > As for dom/lagecy_dom_conformance/, if Firefox fails with them, let's remove
> the
> > tests.
> > As for fast/dom/document-attribute-js-null.html and
> > fast/dom/location-new-window-no-crash.html, it seems we need to update the
> tests
> > for the new behavior.
> https://codereview.chromium.org/2749803003/#ps1
> I fixed all the tests except for "fast/dom/location-new-window-no-crash.html"
as
> I'm unsure if the behavior with the has "h" is correct. Instead of simply
> changing the test, I would like to double check with you that indeed it's
> behaving correctly.

If the expectations of "fast/dom/location-new-window-no-crash.html"
(https://codereview.chromium.org/2749803003/patch/40001/50019) are in accordance
with the standards, the latest patch should solve the issue.

[tkent, 2017-03-15 01:54:21]

> If the expectations of "fast/dom/location-new-window-no-crash.html"
(https://codereview.chromium.org/2749803003/patch/40001/50019) are in accordance
with the standards, the latest patch should solve the issue.

Updated location-new-window-no-crash.html looks correct.  Stndards don't have
exceptions for about:blank, and I confirmed Firefox had same behavior.

lgtm

[tkent, 2017-03-15 01:54:26]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2017-03-15 01:55:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 03:04:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 03:04:07]

Failed to apply patch for
third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt:
While running git apply --index -p1;
  <stdin>:37: trailing whitespace.
  PASS Document interface: xmlDoc must inherit property "documentURI" with the
proper type (2) 
  <stdin>:46: trailing whitespace.
  PASS Node interface: xmlDoc must inherit property "baseURI" with the proper
type (14) 
  <stdin>:55: trailing whitespace.
  PASS Node interface: element must inherit property "baseURI" with the proper
type (14) 
  <stdin>:64: trailing whitespace.
  PASS Node interface: xmlDoc.createProcessingInstruction("abc", "def") must
inherit property "baseURI" with the proper type (14) 
  error: patch failed:
third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt:1
  error:
third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt: patch
does not apply

Patch:      
third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt
Index: third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt
diff --git
a/third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt
b/third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt
index
eb473ab2a64573a96ab539af3332813ce7efe423..ca20a337b401f5d7a56ed43138749a4f072db361
100644
--- a/third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt
+++ b/third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt
@@ -1,6 +1,6 @@
 CONSOLE MESSAGE: line 251: callback not yet supported
 This is a testharness.js-based test.
-Found 1609 tests; 1424 PASS, 185 FAIL, 0 TIMEOUT, 0 NOTRUN.
+Found 1609 tests; 1427 PASS, 182 FAIL, 0 TIMEOUT, 0 NOTRUN.
 PASS Event interface: existence and properties of interface object 
 PASS Event interface object length 
 PASS Event interface object name 
@@ -25,7 +25,7 @@ PASS Event interface: attribute cancelable
 PASS Event interface: operation preventDefault() 
 PASS Event interface: attribute defaultPrevented 
 PASS Event interface: attribute timeStamp 
-FAIL Event interface: operation initEvent(DOMString,boolean,boolean)
assert_equals: property has wrong .length expected 3 but got 0
+FAIL Event interface: operation initEvent(DOMString,boolean,boolean)
assert_equals: property has wrong .length expected 1 but got 0
 PASS Event must be primary interface of document.createEvent("Event") 
 PASS Stringification of document.createEvent("Event") 
 PASS Event interface: document.createEvent("Event") must inherit property
"type" with the proper type (0) 
@@ -76,7 +76,7 @@ PASS CustomEvent interface object name
 FAIL CustomEvent interface: existence and properties of interface prototype
object assert_equals: class string of CustomEvent.prototype expected "[object
CustomEventPrototype]" but got "[object CustomEvent]"
 PASS CustomEvent interface: existence and properties of interface prototype
object's "constructor" property 
 PASS CustomEvent interface: attribute detail 
-PASS CustomEvent interface: operation
initCustomEvent(DOMString,boolean,boolean,any) 
+FAIL CustomEvent interface: operation
initCustomEvent(DOMString,boolean,boolean,any) assert_equals: property has wrong
.length expected 1 but got 4
 PASS CustomEvent must be primary interface of new CustomEvent("foo") 
 PASS Stringification of new CustomEvent("foo") 
 PASS CustomEvent interface: new CustomEvent("foo") must inherit property
"detail" with the proper type (0) 
@@ -412,7 +412,7 @@ PASS XMLDocument must be primary interface of xmlDoc
 PASS Stringification of xmlDoc 
 PASS Document interface: xmlDoc must inherit property "implementation" with the
proper type (0) 
 PASS Document interface: xmlDoc must inherit property "URL" with the proper
type (1) 
-FAIL Document interface: xmlDoc must inherit property "documentURI" with the
proper type (2) assert_equals: expected "string" but got "object"
+PASS Document interface: xmlDoc must inherit property "documentURI" with the
proper type (2) 
 PASS Document interface: xmlDoc must inherit property "origin" with the proper
type (3) 
 PASS Document interface: xmlDoc must inherit property "compatMode" with the
proper type (4) 
 PASS Document interface: xmlDoc must inherit property "characterSet" with the
proper type (5) 
@@ -483,7 +483,7 @@ PASS Node interface: xmlDoc must inherit property
"DOCUMENT_FRAGMENT_NODE" with
 PASS Node interface: xmlDoc must inherit property "NOTATION_NODE" with the
proper type (11) 
 PASS Node interface: xmlDoc must inherit property "nodeType" with the proper
type (12) 
 PASS Node interface: xmlDoc must inherit property "nodeName" with the proper
type (13) 
-FAIL Node interface: xmlDoc must inherit property "baseURI" with the proper
type (14) assert_equals: expected "string" but got "object"
+PASS Node interface: xmlDoc must inherit property "baseURI" with the proper
type (14) 
 PASS Node interface: xmlDoc must inherit property "isConnected" with the proper
type (15) 
 PASS Node interface: xmlDoc must inherit property "ownerDocument" with the
proper type (16) 
 PASS Node interface: xmlDoc must inherit property "getRootNode" with the proper
type (17) 
@@ -894,7 +894,7 @@ PASS Node interface: element must inherit property
"DOCUMENT_FRAGMENT_NODE" with
 PASS Node interface: element must inherit property "NOTATION_NODE" with the
proper type (11) 
 PASS Node interface: element must inherit property "nodeType" with the proper
type (12) 
 PASS Node interface: element must inherit property "nodeName" with the proper
type (13) 
-FAIL Node interface: element must inherit property "baseURI" with the proper
type (14) assert_equals: expected "string" but got "object"
+PASS Node interface: element must inherit property "baseURI" with the proper
type (14) 
 PASS Node interface: element must inherit property "isConnected" with the
proper type (15) 
 PASS Node interface: element must inherit property "ownerDocument" with the
proper type (16) 
 PASS Node interface: element must inherit property "getRootNode" with the
proper type (17) 
@@ -1214,7 +1214,7 @@ PASS Node interface:
xmlDoc.createProcessingInstruction("abc", "def") must inher
 PASS Node interface: xmlDoc.createProcessingInstruction("abc", "def") must
inherit property "NOTATION_NODE" with the proper type (11) 
 PASS Node interface: xmlDoc.createProcessingInstruction("abc", "def") must
inherit property "nodeType" with the proper type (12) 
 PASS Node interface: xmlDoc.createProcessingInstruction("abc", "def") must
inherit property "nodeName" with the proper type (13) 
-FAIL Node interface: xmlDoc.createProcessingInstruction("abc", "def") must
inherit property "baseURI" with the proper type (14) assert_equals: expected
"string" but got "object"
+PASS Node interface: xmlDoc.createProcessingInstruction("abc", "def") must
inherit property "baseURI" with the proper type (14) 
 PASS Node interface: xmlDoc.createProcessingInstruction("abc", "def") must
inherit property "isConnected" with the proper type (15) 
 PASS Node interface: xmlDoc.createProcessingInstruction("abc", "def") must
inherit property "ownerDocument" with the proper type (16) 
 PASS Node interface: xmlDoc.createProcessingInstruction("abc", "def") must
inherit property "getRootNode" with the proper type (17)

[MartinRogalla, 2017-03-15 15:50:58]

On 2017/03/15 03:04:07, commit-bot: I haz the power wrote:
> Failed to apply patch for
> third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt:
> While running git apply --index -p1;
>   <stdin>:37: trailing whitespace.
>   PASS Document interface: xmlDoc must inherit property "documentURI" with the
> proper type (2) 
>   <stdin>:46: trailing whitespace.
>   PASS Node interface: xmlDoc must inherit property "baseURI" with the proper
> type (14) 
>   <stdin>:55: trailing whitespace.
>   PASS Node interface: element must inherit property "baseURI" with the proper
> type (14) 
>   <stdin>:64: trailing whitespace.
>   PASS Node interface: xmlDoc.createProcessingInstruction("abc", "def") must
> inherit property "baseURI" with the proper type (14) 
>   error: patch failed:
> third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt:1
>   error:
> third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt: patch
> does not apply
> 
> Patch:      
> third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt
> Index: third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt
> diff --git
> a/third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt
> b/third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt
> index
>
eb473ab2a64573a96ab539af3332813ce7efe423..ca20a337b401f5d7a56ed43138749a4f072db361
> 100644
> --- a/third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt
> +++ b/third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt
> @@ -1,6 +1,6 @@
>  CONSOLE MESSAGE: line 251: callback not yet supported
>  This is a testharness.js-based test.
> -Found 1609 tests; 1424 PASS, 185 FAIL, 0 TIMEOUT, 0 NOTRUN.
> +Found 1609 tests; 1427 PASS, 182 FAIL, 0 TIMEOUT, 0 NOTRUN.
>  PASS Event interface: existence and properties of interface object 
>  PASS Event interface object length 
>  PASS Event interface object name 
> @@ -25,7 +25,7 @@ PASS Event interface: attribute cancelable
>  PASS Event interface: operation preventDefault() 
>  PASS Event interface: attribute defaultPrevented 
>  PASS Event interface: attribute timeStamp 
> -FAIL Event interface: operation initEvent(DOMString,boolean,boolean)
> assert_equals: property has wrong .length expected 3 but got 0
> +FAIL Event interface: operation initEvent(DOMString,boolean,boolean)
> assert_equals: property has wrong .length expected 1 but got 0
>  PASS Event must be primary interface of document.createEvent("Event") 
>  PASS Stringification of document.createEvent("Event") 
>  PASS Event interface: document.createEvent("Event") must inherit property
> "type" with the proper type (0) 
> @@ -76,7 +76,7 @@ PASS CustomEvent interface object name
>  FAIL CustomEvent interface: existence and properties of interface prototype
> object assert_equals: class string of CustomEvent.prototype expected "[object
> CustomEventPrototype]" but got "[object CustomEvent]"
>  PASS CustomEvent interface: existence and properties of interface prototype
> object's "constructor" property 
>  PASS CustomEvent interface: attribute detail 
> -PASS CustomEvent interface: operation
> initCustomEvent(DOMString,boolean,boolean,any) 
> +FAIL CustomEvent interface: operation
> initCustomEvent(DOMString,boolean,boolean,any) assert_equals: property has
wrong
> .length expected 1 but got 4
>  PASS CustomEvent must be primary interface of new CustomEvent("foo") 
>  PASS Stringification of new CustomEvent("foo") 
>  PASS CustomEvent interface: new CustomEvent("foo") must inherit property
> "detail" with the proper type (0) 
> @@ -412,7 +412,7 @@ PASS XMLDocument must be primary interface of xmlDoc
>  PASS Stringification of xmlDoc 
>  PASS Document interface: xmlDoc must inherit property "implementation" with
the
> proper type (0) 
>  PASS Document interface: xmlDoc must inherit property "URL" with the proper
> type (1) 
> -FAIL Document interface: xmlDoc must inherit property "documentURI" with the
> proper type (2) assert_equals: expected "string" but got "object"
> +PASS Document interface: xmlDoc must inherit property "documentURI" with the
> proper type (2) 
>  PASS Document interface: xmlDoc must inherit property "origin" with the
proper
> type (3) 
>  PASS Document interface: xmlDoc must inherit property "compatMode" with the
> proper type (4) 
>  PASS Document interface: xmlDoc must inherit property "characterSet" with the
> proper type (5) 
> @@ -483,7 +483,7 @@ PASS Node interface: xmlDoc must inherit property
> "DOCUMENT_FRAGMENT_NODE" with
>  PASS Node interface: xmlDoc must inherit property "NOTATION_NODE" with the
> proper type (11) 
>  PASS Node interface: xmlDoc must inherit property "nodeType" with the proper
> type (12) 
>  PASS Node interface: xmlDoc must inherit property "nodeName" with the proper
> type (13) 
> -FAIL Node interface: xmlDoc must inherit property "baseURI" with the proper
> type (14) assert_equals: expected "string" but got "object"
> +PASS Node interface: xmlDoc must inherit property "baseURI" with the proper
> type (14) 
>  PASS Node interface: xmlDoc must inherit property "isConnected" with the
proper
> type (15) 
>  PASS Node interface: xmlDoc must inherit property "ownerDocument" with the
> proper type (16) 
>  PASS Node interface: xmlDoc must inherit property "getRootNode" with the
proper
> type (17) 
> @@ -894,7 +894,7 @@ PASS Node interface: element must inherit property
> "DOCUMENT_FRAGMENT_NODE" with
>  PASS Node interface: element must inherit property "NOTATION_NODE" with the
> proper type (11) 
>  PASS Node interface: element must inherit property "nodeType" with the proper
> type (12) 
>  PASS Node interface: element must inherit property "nodeName" with the proper
> type (13) 
> -FAIL Node interface: element must inherit property "baseURI" with the proper
> type (14) assert_equals: expected "string" but got "object"
> +PASS Node interface: element must inherit property "baseURI" with the proper
> type (14) 
>  PASS Node interface: element must inherit property "isConnected" with the
> proper type (15) 
>  PASS Node interface: element must inherit property "ownerDocument" with the
> proper type (16) 
>  PASS Node interface: element must inherit property "getRootNode" with the
> proper type (17) 
> @@ -1214,7 +1214,7 @@ PASS Node interface:
> xmlDoc.createProcessingInstruction("abc", "def") must inher
>  PASS Node interface: xmlDoc.createProcessingInstruction("abc", "def") must
> inherit property "NOTATION_NODE" with the proper type (11) 
>  PASS Node interface: xmlDoc.createProcessingInstruction("abc", "def") must
> inherit property "nodeType" with the proper type (12) 
>  PASS Node interface: xmlDoc.createProcessingInstruction("abc", "def") must
> inherit property "nodeName" with the proper type (13) 
> -FAIL Node interface: xmlDoc.createProcessingInstruction("abc", "def") must
> inherit property "baseURI" with the proper type (14) assert_equals: expected
> "string" but got "object"
> +PASS Node interface: xmlDoc.createProcessingInstruction("abc", "def") must
> inherit property "baseURI" with the proper type (14) 
>  PASS Node interface: xmlDoc.createProcessingInstruction("abc", "def") must
> inherit property "isConnected" with the proper type (15) 
>  PASS Node interface: xmlDoc.createProcessingInstruction("abc", "def") must
> inherit property "ownerDocument" with the proper type (16) 
>  PASS Node interface: xmlDoc.createProcessingInstruction("abc", "def") must
> inherit property "getRootNode" with the proper type (17)

Ehm, I didn't see something like this before. Is there any action from me
required? Strange that it didn't work since the tests passed...

[tkent, 2017-03-15 21:00:39]

On 2017/03/15 at 15:50:58, martin wrote:
> Ehm, I didn't see something like this before. Is there any action from me
required? Strange that it didn't work since the tests passed...

It's just a patch conflict.  Someone modified interfaces-expected.txt after try
bots succeeded for this CL.
You need to do rebase on HEAD and upload again.

[MartinRogalla, 2017-03-16 02:31:16]

The CQ bit was checked by martin@martinrogalla.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 02:31:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[MartinRogalla, 2017-03-16 02:45:32]

On 2017/03/15 21:00:39, tkent wrote:
> On 2017/03/15 at 15:50:58, martin wrote:
> > Ehm, I didn't see something like this before. Is there any action from me
> required? Strange that it didn't work since the tests passed...
> 
> It's just a patch conflict.  Someone modified interfaces-expected.txt after
try
> bots succeeded for this CL.
> You need to do rebase on HEAD and upload again.

Ok, thanks. I just rebased it.

[commit-bot: I haz the power, 2017-03-16 03:45:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 03:45:38]

Dry run: This issue passed the CQ dry run.

[MartinRogalla, 2017-03-16 04:01:46]

The CQ bit was checked by martin@martinrogalla.com

[MartinRogalla, 2017-03-16 04:01:47]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2749803003/#ps60001
(title: "Rebased.")

[commit-bot: I haz the power, 2017-03-16 04:02:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 04:07:48]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489636906921250,
"parent_rev": "bc7bbd667335209110948cd2f07b4e3b7f44b56c", "commit_rev":
"9168f165fe92e37664a5e39fef987f0e3ad72a62"}

[commit-bot: I haz the power, 2017-03-16 04:08:27]

Description was changed from

==========
Initialize document m_URL & m_baseURL to blankURL.

This patch will ensure that m_URL and m_baseURL are initialized to
blankURL (about:blank) as is specified in [1]. This patch fixes the
tests in [2] and [3].

[1] https://dom.spec.whatwg.org/#interface-document
[2] http://w3c-test.org/dom/nodes/DOMImplementation-createDocument.html
[3] http://w3c-test.org/dom/nodes/DOMImplementation-createHTMLDocument.html

BUG=563986
==========

to

==========
Initialize document m_URL & m_baseURL to blankURL.

This patch will ensure that m_URL and m_baseURL are initialized to
blankURL (about:blank) as is specified in [1]. This patch fixes the
tests in [2] and [3].

[1] https://dom.spec.whatwg.org/#interface-document
[2] http://w3c-test.org/dom/nodes/DOMImplementation-createDocument.html
[3] http://w3c-test.org/dom/nodes/DOMImplementation-createHTMLDocument.html

BUG=563986

Review-Url: https://codereview.chromium.org/2749803003
Cr-Commit-Position: refs/heads/master@{#457347}
Committed:
https://chromium.googlesource.com/chromium/src/+/9168f165fe92e37664a5e39fef98...
==========

[commit-bot: I haz the power, 2017-03-16 04:08:28]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9168f165fe92e37664a5e39fef98...

[tzik, 2017-03-16 06:31:51]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2757573002/ by tzik@chromium.org.

The reason for reverting is: This CL seems to break interactive_ui_tests on
multiple bots:

A sample of error log was:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...

../../chrome/test/base/extension_js_browser_test.cc:64: Failure
Failed
Failed: RUN_TEST_F("AutomationTreeWalkerTest","Backward")
ReferenceError: DesktopAutomationHandler is not defined
    at AutomationTreeWalkerTest.ChromeVoxNextE2ETest
(tree_walker_test.extjs:8556:3)
    at AutomationTreeWalkerTest (tree_walker_test.extjs:8663:24)
    at createTestCase (tree_walker_test.extjs:7607:19)
    at RUN_TEST_F (tree_walker_test.extjs:7721:25)
    at tree_walker_test.extjs:7523:20
    at runTestFunction (tree_walker_test.extjs:7593:37)
    at runTest (tree_walker_test.extjs:7567:18)
    at tree_walker_test.extjs:8851:1
gen/chrome/browser/resources/chromeos/chromevox/cvox2/background/tree_walker_test-gen.cc:69:
Failure
Value of: RunJavascriptTestF( true, "AutomationTreeWalkerTest", "Backward")
  Actual: false
Expected: true
[  FAILED  ] AutomationTreeWalkerTest.Backward, where TypeParam =  and
GetParam() =  (1196 ms).

[Ken Rockot(use gerrit already), 2017-03-16 06:36:37]

On 2017/03/16 at 06:31:51, tzik wrote:
> A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2757573002/ by tzik@chromium.org.
> 
> The reason for reverting is: This CL seems to break interactive_ui_tests on
multiple bots:
> 
> A sample of error log was:
>
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
> 
> ../../chrome/test/base/extension_js_browser_test.cc:64: Failure
> Failed
> Failed: RUN_TEST_F("AutomationTreeWalkerTest","Backward")
> ReferenceError: DesktopAutomationHandler is not defined
>     at AutomationTreeWalkerTest.ChromeVoxNextE2ETest
(tree_walker_test.extjs:8556:3)
>     at AutomationTreeWalkerTest (tree_walker_test.extjs:8663:24)
>     at createTestCase (tree_walker_test.extjs:7607:19)
>     at RUN_TEST_F (tree_walker_test.extjs:7721:25)
>     at tree_walker_test.extjs:7523:20
>     at runTestFunction (tree_walker_test.extjs:7593:37)
>     at runTest (tree_walker_test.extjs:7567:18)
>     at tree_walker_test.extjs:8851:1
>
gen/chrome/browser/resources/chromeos/chromevox/cvox2/background/tree_walker_test-gen.cc:69:
Failure
> Value of: RunJavascriptTestF( true, "AutomationTreeWalkerTest", "Backward")
>   Actual: false
> Expected: true
> [  FAILED  ] AutomationTreeWalkerTest.Backward, where TypeParam =  and
GetParam() =  (1196 ms).

FYI there are many other test failures on multiple bots. See for example:

https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel...
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel...

These all appear to be related. I suspect that having a non-empty URL on
Document construction has some subtle unanticipated side-effects that need to be
remedied.

[brucedawson, 2017-03-16 18:28:06]

The CL also seemed to break browser_tests on ChromeOS:

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2FLi...

Lots of "Set OOM score error:" followed by (TIMED OUT). When the revert landed
the bot went green again. The only CL in the build where things went from purple
to green was the revert. FWIW.

First green build is here:

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...

[tkent, 2017-03-17 08:25:03]

Though I'm not sure why trybots didn't catch the problems, I reproduced some
test failures locally on Mac.

% ninja ... -C out/debug content_browsertets
% ./out/debug/content_browsertests
--gtest_filter=NavigationControllerBrowserTest.ErrorPageReplacement

It seems we have many code assuming Document initially has empty URL instead of
about:blank.

One possible workaround is:
 - Don't change initial value of m_url.
 - Add new function Document::urlForBinding().  It returns "about:blank" if
m_url is empty.
 - Add ImplementedAs=urlForBinding to URL and documentURI in Document.idl.

[MartinRogalla, 2017-03-17 22:05:55]

On 2017/03/17 08:25:03, tkent wrote:
> Though I'm not sure why trybots didn't catch the problems, I reproduced some
> test failures locally on Mac.
> 
> % ninja ... -C out/debug content_browsertets
> % ./out/debug/content_browsertests
> --gtest_filter=NavigationControllerBrowserTest.ErrorPageReplacement
> 
> It seems we have many code assuming Document initially has empty URL instead
of
> about:blank.
> 
> One possible workaround is:
>  - Don't change initial value of m_url.
>  - Add new function Document::urlForBinding().  It returns "about:blank" if
> m_url is empty.
>  - Add ImplementedAs=urlForBinding to URL and documentURI in Document.idl.

Sounds good, I'll implement it and try to run the previously failing tests
locally.