Issue 2775683003: ChromeOS OOBE: replace i18n macro with i18n-values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2775683003: ChromeOS OOBE: replace i18n macro with i18n-values (Closed)

Created:
3 years, 9 months ago by Alexander Alekseev

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3029

Project:
chromium

Visibility:
Public.

ChromeOS OOBE: replace i18n macro with i18n-values i18n macro doesn't support language switching, so we need to use i18n-values. BUG=704028 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2767693003 Cr-Commit-Position: refs/heads/master@{#458970} (cherry picked from commit 893656ac30d6e0d8afef9d0ce458276effb36dff) Review-Url: https://codereview.chromium.org/2775683003 . Cr-Commit-Position: refs/branch-heads/3029@{#403} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/be466fe8438ba3cee1958da07cb0944666b30536

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome/browser/resources/chromeos/login/oobe_eula.html	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 2 (1 generated)

Alexander Alekseev

3 years, 9 months ago (2017-03-24 05:38:13 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
be466fe8438ba3cee1958da07cb0944666b30536.