Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2767693003: ChromeOS OOBE: replace i18n macro with i18n-values (Closed)

Created:
3 years, 9 months ago by Alexander Alekseev
Modified:
3 years, 9 months ago
Reviewers:
jdufault
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS OOBE: replace i18n macro with i18n-values i18n macro doesn't support language switching, so we need to use i18n-values. BUG=704028 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2767693003 Cr-Commit-Position: refs/heads/master@{#458970} Committed: https://chromium.googlesource.com/chromium/src/+/893656ac30d6e0d8afef9d0ce458276effb36dff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_eula.html View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Alexander Alekseev
Please review.
3 years, 9 months ago (2017-03-22 08:10:00 UTC) #3
jdufault
On 2017/03/22 08:10:00, Alexander Alekseev wrote: > Please review. nice catch, lgtm
3 years, 9 months ago (2017-03-22 16:52:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767693003/1
3 years, 9 months ago (2017-03-22 22:59:39 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 01:28:08 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/893656ac30d6e0d8afef9d0ce458...

Powered by Google App Engine
This is Rietveld 408576698