Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2775683002: CrOS: Apply flag which enables us to force maximize mode. (Closed)

Created:
3 years, 9 months ago by sammiequon
Modified:
3 years, 8 months ago
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

CrOS: Apply flag which enables us to force maximize mode. There is a flag which lets user choose if they want to force clamshell/touchView mode regardless of device orientation(s). This CL applys the functionality of that flag. TEST=ash_unittests --gtest_filter="MaximizeModeControllerTest.Force*" BUG=701135 Review-Url: https://codereview.chromium.org/2775683002 Cr-Commit-Position: refs/heads/master@{#460429} Committed: https://chromium.googlesource.com/chromium/src/+/1d6e7115c66667ae3f401de68bf7cfbc7e694f79

Patch Set 1 #

Patch Set 2 #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -21 lines) Patch
M ash/common/ash_switches.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ash/common/ash_switches.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M ash/common/wm/maximize_mode/maximize_mode_controller.h View 1 2 4 chunks +17 lines, -0 lines 0 comments Download
M ash/common/wm/maximize_mode/maximize_mode_controller.cc View 1 2 6 chunks +35 lines, -0 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_controller_unittest.cc View 1 2 2 chunks +44 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 2 chunks +11 lines, -8 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 1 chunk +0 lines, -9 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (11 generated)
sammiequon
skuhne@ - Please take a look. Thanks!
3 years, 9 months ago (2017-03-23 19:10:45 UTC) #3
sammiequon
On 2017/03/23 19:10:45, sammiequon wrote: > skuhne@ - Please take a look. Thanks! skuhne@ - ...
3 years, 8 months ago (2017-03-28 17:55:51 UTC) #5
Mr4D (OOO till 08-26)
lgtm
3 years, 8 months ago (2017-03-28 18:21:48 UTC) #6
sammiequon
On 2017/03/28 18:21:48, Mr4D wrote: > lgtm Thanks!
3 years, 8 months ago (2017-03-28 18:59:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775683002/40001
3 years, 8 months ago (2017-03-29 17:04:42 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 17:10:31 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1d6e7115c66667ae3f401de68bf7...

Powered by Google App Engine
This is Rietveld 408576698