Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 2765373002: CrOS: Move force UI mode switch from switches to ash switches. (Closed)

Created:
3 years, 9 months ago by sammiequon
Modified:
3 years, 8 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, kalyank, sadrul, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

CrOS: Move force UI mode switch from switches to ash switches. We will need this switch in ash switches to use with ash. See dependent patchset for usage. TEST=unit_tests --gtest_filter="AboutFlagsHistogramTest.*" BUG=701135 Review-Url: https://codereview.chromium.org/2765373002 Cr-Commit-Position: refs/heads/master@{#460391} Committed: https://chromium.googlesource.com/chromium/src/+/df9bf7c32b4361a7b66a241317ca3571f58c28b3

Patch Set 1 #

Patch Set 2 #

Total comments: 5

Patch Set 3 : Patch set 2. #

Patch Set 4 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -21 lines) Patch
M ash/common/ash_switches.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ash/common/ash_switches.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 2 chunks +11 lines, -8 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 1 chunk +0 lines, -9 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (18 generated)
sammiequon
derat@ - Please take a look. Thanks!
3 years, 8 months ago (2017-03-28 19:02:38 UTC) #3
Daniel Erat
https://codereview.chromium.org/2765373002/diff/20001/ash/common/ash_switches.cc File ash/common/ash_switches.cc (right): https://codereview.chromium.org/2765373002/diff/20001/ash/common/ash_switches.cc#newcode73 ash/common/ash_switches.cc:73: // chromebook is currently in the selected UI mode. ...
3 years, 8 months ago (2017-03-28 19:30:13 UTC) #4
sammiequon
https://codereview.chromium.org/2765373002/diff/20001/ash/common/ash_switches.cc File ash/common/ash_switches.cc (right): https://codereview.chromium.org/2765373002/diff/20001/ash/common/ash_switches.cc#newcode73 ash/common/ash_switches.cc:73: // chromebook is currently in the selected UI mode. ...
3 years, 8 months ago (2017-03-28 20:32:00 UTC) #5
Daniel Erat
lgtm https://codereview.chromium.org/2765373002/diff/20001/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): https://codereview.chromium.org/2765373002/diff/20001/chrome/browser/about_flags.cc#newcode2399 chrome/browser/about_flags.cc:2399: {"ash-force-tablet-mode", IDS_FLAGS_FORCE_TABLET_MODE_NAME, On 2017/03/28 20:32:00, sammiequon wrote: > ...
3 years, 8 months ago (2017-03-28 20:35:33 UTC) #6
sammiequon
On 2017/03/28 20:35:33, Daniel Erat wrote: > lgtm > > https://codereview.chromium.org/2765373002/diff/20001/chrome/browser/about_flags.cc > File chrome/browser/about_flags.cc (right): ...
3 years, 8 months ago (2017-03-28 20:44:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2765373002/60001
3 years, 8 months ago (2017-03-29 15:11:41 UTC) #22
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 15:18:00 UTC) #25
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/df9bf7c32b4361a7b66a241317ca...

Powered by Google App Engine
This is Rietveld 408576698