Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2775633004: Report errors on non-final fields in const classes. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
karlklose, Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -10 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 4 chunks +22 lines, -7 lines 0 comments Download
M tests/co19/co19-kernel.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_kernel.status View 2 chunks +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 6 (3 generated)
ahe
3 years, 9 months ago (2017-03-24 12:39:58 UTC) #3
karlklose
LGTM
3 years, 9 months ago (2017-03-24 13:14:25 UTC) #4
ahe
3 years, 9 months ago (2017-03-24 14:10:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
0c17ebba9f8dac346f75e2155e1f921b8f259f18 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698