Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2771983004: Implement character offsets for fields and enum constants. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
jensj
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, dart-fe-team+reviews_google.com, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement character offsets for fields and enum constants. R=jensj@google.com Committed: https://github.com/dart-lang/sdk/commit/ec5d7cba1a6fffbfcae1bbd667876c3a9f6c904e

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove TODO. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -62 lines) Patch
M pkg/front_end/lib/src/fasta/builder/enum_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart View 8 chunks +14 lines, -15 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 1 23 chunks +105 lines, -36 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 2 chunks +6 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/unhandled_listener.dart View 3 chunks +7 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/get_source_report_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2775633004 Patch 20001

Messages

Total messages: 7 (3 generated)
ahe
3 years, 9 months ago (2017-03-24 12:43:38 UTC) #3
jensj
lgtm https://codereview.chromium.org/2771983004/diff/20001/pkg/front_end/lib/src/fasta/source/outline_builder.dart File pkg/front_end/lib/src/fasta/source/outline_builder.dart (right): https://codereview.chromium.org/2771983004/diff/20001/pkg/front_end/lib/src/fasta/source/outline_builder.dart#newcode477 pkg/front_end/lib/src/fasta/source/outline_builder.dart:477: // TODO(ahe): Needs begin token. Is this todo ...
3 years, 9 months ago (2017-03-24 12:49:10 UTC) #4
ahe
Thank you, Jens! https://codereview.chromium.org/2771983004/diff/20001/pkg/front_end/lib/src/fasta/source/outline_builder.dart File pkg/front_end/lib/src/fasta/source/outline_builder.dart (right): https://codereview.chromium.org/2771983004/diff/20001/pkg/front_end/lib/src/fasta/source/outline_builder.dart#newcode477 pkg/front_end/lib/src/fasta/source/outline_builder.dart:477: // TODO(ahe): Needs begin token. On ...
3 years, 9 months ago (2017-03-24 14:11:50 UTC) #5
ahe
3 years, 9 months ago (2017-03-24 14:29:50 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20002) manually as
ec5d7cba1a6fffbfcae1bbd667876c3a9f6c904e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698