Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issue 2775263002: [Prerender] Remove the "wash" origin in prerender histograms (Closed)

Created:
3 years, 9 months ago by droger
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Prerender] Remove the "wash" origin in prerender histograms This origin was introduced at a time where the prerender metrics were unable to keep track of multiple origins simultaneously. When several origins were active at once, the origin would be reported as a "wash". This limitation no longer exists, and origins now don't interfere with each other. Moreover, the wash origin is actually harmful now because it destroys information. BUG=704868 Review-Url: https://codereview.chromium.org/2769903005 Cr-Commit-Position: refs/heads/master@{#459437} (cherry picked from commit 9aac56e95a24dcdeec343f906922f06cddfdf5a5) Review-Url: https://codereview.chromium.org/2775263002 . Cr-Commit-Position: refs/branch-heads/3029@{#423} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/0c7714ff66b36ad6bcbfbc74ed44e6e2652c8e5c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -75 lines) Patch
M chrome/browser/prerender/prerender_histograms.h View 2 chunks +1 line, -11 lines 0 comments Download
M chrome/browser/prerender/prerender_histograms.cc View 11 chunks +21 lines, -62 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
droger
3 years, 9 months ago (2017-03-27 11:48:49 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0c7714ff66b36ad6bcbfbc74ed44e6e2652c8e5c.

Powered by Google App Engine
This is Rietveld 408576698