[Prerender] Remove the "wash" origin in prerender histograms

[Prerender] Remove the "wash" origin in prerender histograms

This origin was introduced at a time where the prerender metrics
were unable to keep track of multiple origins simultaneously.
When several origins were active at once, the origin would be reported
as a "wash".

This limitation no longer exists, and origins now don't interfere with
each other. Moreover, the wash origin is actually harmful now because
it destroys information.

BUG=704868
Review-Url: https://codereview.chromium.org/2769903005
Cr-Commit-Position: refs/heads/master@{#459437}
Committed: https://chromium.googlesource.com/chromium/src/+/9aac56e95a24dcdeec343f906922f06cddfdf5a5

[droger, 2017-03-23 17:31:18]

The CQ bit was checked by droger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 17:31:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 18:28:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 18:28:35]

Dry run: This issue passed the CQ dry run.

[droger, 2017-03-24 09:24:40]

Description was changed from

==========
remove wash

BUG=
==========

to

==========
[Prerender] Remove the "wash" origin in prerender histograms

This origin was introduced at a time where the prerender metrics
were unable to keep track of multiple origin simultaneously.
When several origin were active at once, the origin would be reported
as a "wash".

This limitation no longer exists, and origins now don't interfere with
each other. Moreover, the wash origin is actually harmful now because
it destroys information.
==========

[droger, 2017-03-24 09:36:11]

Description was changed from

==========
[Prerender] Remove the "wash" origin in prerender histograms

This origin was introduced at a time where the prerender metrics
were unable to keep track of multiple origin simultaneously.
When several origin were active at once, the origin would be reported
as a "wash".

This limitation no longer exists, and origins now don't interfere with
each other. Moreover, the wash origin is actually harmful now because
it destroys information.
==========

to

==========
[Prerender] Remove the "wash" origin in prerender histograms

This origin was introduced at a time where the prerender metrics
were unable to keep track of multiple origin simultaneously.
When several origin were active at once, the origin would be reported
as a "wash".

This limitation no longer exists, and origins now don't interfere with
each other. Moreover, the wash origin is actually harmful now because
it destroys information.

BUG=704868
==========

[droger, 2017-03-24 09:36:24]

droger@chromium.org changed reviewers:
+ mattcary@chromium.org, pasko@chromium.org

[droger, 2017-03-24 09:37:31]

Description was changed from

==========
[Prerender] Remove the "wash" origin in prerender histograms

This origin was introduced at a time where the prerender metrics
were unable to keep track of multiple origin simultaneously.
When several origin were active at once, the origin would be reported
as a "wash".

This limitation no longer exists, and origins now don't interfere with
each other. Moreover, the wash origin is actually harmful now because
it destroys information.

BUG=704868
==========

to

==========
[Prerender] Remove the "wash" origin in prerender histograms

This origin was introduced at a time where the prerender metrics
were unable to keep track of multiple origins simultaneously.
When several origin were active at once, the origin would be reported
as a "wash".

This limitation no longer exists, and origins now don't interfere with
each other. Moreover, the wash origin is actually harmful now because
it destroys information.

BUG=704868
==========

[droger, 2017-03-24 09:37:44]

Description was changed from

==========
[Prerender] Remove the "wash" origin in prerender histograms

This origin was introduced at a time where the prerender metrics
were unable to keep track of multiple origins simultaneously.
When several origin were active at once, the origin would be reported
as a "wash".

This limitation no longer exists, and origins now don't interfere with
each other. Moreover, the wash origin is actually harmful now because
it destroys information.

BUG=704868
==========

to

==========
[Prerender] Remove the "wash" origin in prerender histograms

This origin was introduced at a time where the prerender metrics
were unable to keep track of multiple origins simultaneously.
When several origins were active at once, the origin would be reported
as a "wash".

This limitation no longer exists, and origins now don't interfere with
each other. Moreover, the wash origin is actually harmful now because
it destroys information.

BUG=704868
==========

[mattcary, 2017-03-24 12:20:13]

lgtm

After Egor checks in his tear-out-PerceivedPLT-histograms CL, I think the
WithinWindow function will be unused and can be torn out, along with
GetTimeSinceLastPrerender and last_prererender_seen_time.

Or maybe if you get your CL in first, Egor will be the one to have to remove it
;)

[droger, 2017-03-24 12:37:05]

As per Egor's message on the other CL, lets land this one first.

[droger, 2017-03-24 12:38:41]

The CQ bit was checked by droger@chromium.org

[commit-bot: I haz the power, 2017-03-24 12:38:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pasko, 2017-03-24 12:45:23]

overall looks good, let's deprecate <suffix name="wash" ...> in histograms.xml
as well

https://codereview.chromium.org/2769903005/diff/1/chrome/browser/prerender/pr...
File chrome/browser/prerender/prerender_histograms.cc (right):

https://codereview.chromium.org/2769903005/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_histograms.cc:81: return
ComposeHistogramName("none", name);
fun fact: this costs ~26 bytes in android-arm binary :)

https://codereview.chromium.org/2769903005/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_histograms.cc:96: // macros will eventually
substitute for the actual name used.
nit: one more s/macros/macro/

[pasko, 2017-03-24 12:46:05]

The CQ bit was unchecked by pasko@chromium.org

[droger, 2017-03-24 13:00:25]

The CQ bit was checked by droger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 13:00:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[droger, 2017-03-24 13:01:31]

droger@chromium.org changed reviewers:
+ rkaplow@chromium.org

[droger, 2017-03-24 13:01:32]

Thanks, please take a look.

+rkaplow for histograms.xml

[pasko, 2017-03-24 13:14:02]

lgtm thank you

[commit-bot: I haz the power, 2017-03-24 14:10:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 14:10:56]

Dry run: This issue passed the CQ dry run.

[rkaplow, 2017-03-24 15:44:01]

lgtm

[droger, 2017-03-24 15:49:03]

The CQ bit was checked by droger@chromium.org

[droger, 2017-03-24 15:49:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
mattcary@chromium.org
Link to the patchset: https://codereview.chromium.org/2769903005/#ps40001
(title: "typo")

[commit-bot: I haz the power, 2017-03-24 15:49:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 15:54:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490370543751840,
"parent_rev": "82a6458a23cf1be17524e2d329e8f1c5668acb22", "commit_rev":
"9aac56e95a24dcdeec343f906922f06cddfdf5a5"}

[commit-bot: I haz the power, 2017-03-24 15:55:24]

Description was changed from

==========
[Prerender] Remove the "wash" origin in prerender histograms

This origin was introduced at a time where the prerender metrics
were unable to keep track of multiple origins simultaneously.
When several origins were active at once, the origin would be reported
as a "wash".

This limitation no longer exists, and origins now don't interfere with
each other. Moreover, the wash origin is actually harmful now because
it destroys information.

BUG=704868
==========

to

==========
[Prerender] Remove the "wash" origin in prerender histograms

This origin was introduced at a time where the prerender metrics
were unable to keep track of multiple origins simultaneously.
When several origins were active at once, the origin would be reported
as a "wash".

This limitation no longer exists, and origins now don't interfere with
each other. Moreover, the wash origin is actually harmful now because
it destroys information.

BUG=704868

Review-Url: https://codereview.chromium.org/2769903005
Cr-Commit-Position: refs/heads/master@{#459437}
Committed:
https://chromium.googlesource.com/chromium/src/+/9aac56e95a24dcdeec343f906922...
==========

[commit-bot: I haz the power, 2017-03-24 15:55:26]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9aac56e95a24dcdeec343f906922...