[builtins] Implement %TypedArray%.prototype.{some,every} in the CSA

[builtins] Implement %TypedArray%.prototype.{some,every} in the CSA

R=mvstanton@chromium.org,danno@chromium.org

Review-Url: https://codereview.chromium.org/2775203002
Cr-Commit-Position: refs/heads/master@{#44274}
Committed: https://chromium.googlesource.com/v8/v8/+/e837594cd8308d4f8d27000c7e4907b2c23bbb42

[Tobias Tebbi, 2017-03-27 11:46:20]

Patchset #3 (id:40001) has been deleted

[danno, 2017-03-28 09:44:36]

Nice. lgtm.

[mvstanton, 2017-03-28 15:01:24]

LGTM, one comment. Nice!

https://codereview.chromium.org/2775203002/diff/60001/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/2775203002/diff/60001/src/bootstrapper.cc#new...
src/bootstrapper.cc:3727: InstallOneBuiltinFunction(typed_array_prototype,
"every",
Maybe it makes sense to remove InstallOneBuiltinFunction(char *name, ...),

And just look up the array prototype here. This is the only place
InstallOneBuiltinFunction is called.

[Tobias Tebbi, 2017-03-29 08:45:30]

The CQ bit was checked by tebbi@chromium.org

[Tobias Tebbi, 2017-03-29 08:45:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvstanton@chromium.org, danno@chromium.org
Link to the patchset: https://codereview.chromium.org/2775203002/#ps80001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-03-29 08:45:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 08:46:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 08:46:45]

Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/37920)

[Tobias Tebbi, 2017-03-29 09:03:17]

The CQ bit was checked by tebbi@chromium.org

[Tobias Tebbi, 2017-03-29 09:03:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvstanton@chromium.org, danno@chromium.org
Link to the patchset: https://codereview.chromium.org/2775203002/#ps100001
(title: "Rebased.")

[commit-bot: I haz the power, 2017-03-29 09:03:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tobias Tebbi, 2017-03-29 09:11:47]

The CQ bit was unchecked by tebbi@chromium.org

[Tobias Tebbi, 2017-03-29 09:27:13]

Thanks to Peter's amazing new documentation of TypedArrays
(https://docs.google.com/document/d/1umCT57FhjDieYm8qs161z-cPgKIHuVFIJCSvBcHWJg4/),
we just realized that my CL contains a serious bug: If typedarray.buffer is
called in the callback, the backing store is switched to an external one, making
the loop read from garbage.

[Tobias Tebbi, 2017-03-29 09:27:13]

Thanks to Peter's amazing new documentation of TypedArrays
(https://docs.google.com/document/d/1umCT57FhjDieYm8qs161z-cPgKIHuVFIJCSvBcHWJg4/),
we just realized that my CL contains a serious bug: If typedarray.buffer is
called in the callback, the backing store is switched to an external one, making
the loop read from garbage.

[Tobias Tebbi, 2017-03-29 09:55:29]

I fixed the bug and added a test, PTAL

[petermarshall, 2017-03-29 13:21:57]

petermarshall@chromium.org changed reviewers:
+ petermarshall@chromium.org

[petermarshall, 2017-03-29 13:21:58]

lgtm

LGTM with nits!

https://codereview.chromium.org/2775203002/diff/120001/src/builtins/builtins-...
File src/builtins/builtins-array-gen.cc (right):

https://codereview.chromium.org/2775203002/diff/120001/src/builtins/builtins-...
src/builtins/builtins-array-gen.cc:306: Label not_typed_array(this,
Label::kDeferred),
I would rename not_typed_array to say what it does, not how we get there, e.g.
rename it to throw_not_typed_array or something.

https://codereview.chromium.org/2775203002/diff/120001/src/builtins/builtins-...
src/builtins/builtins-array-gen.cc:319: Label not_callable(this,
Label::kDeferred);
Same here, throw_not_callable

[Tobias Tebbi, 2017-03-30 16:00:48]

The CQ bit was checked by tebbi@chromium.org

[Tobias Tebbi, 2017-03-30 16:00:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvstanton@chromium.org, danno@chromium.org, petermarshall@chromium.org
Link to the patchset: https://codereview.chromium.org/2775203002/#ps140001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-03-30 16:00:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 16:36:54]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1490889648537730,
"parent_rev": "e803448767809f8832b7023da7557164ec0836c4", "commit_rev":
"e837594cd8308d4f8d27000c7e4907b2c23bbb42"}

[commit-bot: I haz the power, 2017-03-30 16:37:00]

Description was changed from

==========
[builtins] Implement %TypedArray%.prototype.{some,every} in the CSA

R=mvstanton@chromium.org,danno@chromium.org
==========

to

==========
[builtins] Implement %TypedArray%.prototype.{some,every} in the CSA

R=mvstanton@chromium.org,danno@chromium.org

Review-Url: https://codereview.chromium.org/2775203002
Cr-Commit-Position: refs/heads/master@{#44274}
Committed:
https://chromium.googlesource.com/v8/v8/+/e837594cd8308d4f8d27000c7e4907b2c23...
==========

[commit-bot: I haz the power, 2017-03-30 16:37:01]

Committed patchset #7 (id:140001) as
https://chromium.googlesource.com/v8/v8/+/e837594cd8308d4f8d27000c7e4907b2c23...