[builtins] Implement %TypedArray%.prototype.{some,every} in the CSA

src/bootstrapper.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/bootstrapper.h"
 
 #include "src/accessors.h"
 #include "src/api-natives.h"
 #include "src/base/ieee754.h"
 #include "src/code-stubs.h"
@@ skipping 200 matching lines @@
 #define DECLARE_FEATURE_INITIALIZATION(id, descr) \
   void InitializeGlobal_##id();
 
   HARMONY_INPROGRESS(DECLARE_FEATURE_INITIALIZATION)
   HARMONY_STAGED(DECLARE_FEATURE_INITIALIZATION)
   HARMONY_SHIPPING(DECLARE_FEATURE_INITIALIZATION)
 #undef DECLARE_FEATURE_INITIALIZATION
 
   void InstallOneBuiltinFunction(const char* object, const char* method,
                                  Builtins::Name name);
+  void InstallOneBuiltinFunction(Handle<Object> prototype, const char* method,
+                                 Builtins::Name name);
   void InitializeGlobal_experimental_fast_array_builtins();
 
   Handle<JSFunction> InstallArrayBuffer(Handle<JSObject> target,
                                         const char* name,
                                         Builtins::Name call_byteLength,
                                         BuiltinFunctionId byteLength_id,
                                         Builtins::Name call_slice);
   Handle<JSFunction> InstallInternalArray(Handle<JSObject> target,
                                           const char* name,
                                           ElementsKind elements_kind);
@@ skipping 3452 matching lines @@
   Handle<String> name_string = factory->InternalizeUtf8String(name);
   PropertyAttributes attributes =
       static_cast<PropertyAttributes>(DONT_ENUM | DONT_DELETE | READ_ONLY);
   JSObject::AddProperty(symbol, name_string, value, attributes);
 }
 
 void Genesis::InstallOneBuiltinFunction(const char* object_name,
                                         const char* method_name,
                                         Builtins::Name builtin_name) {
   Handle<JSGlobalObject> global(native_context()->global_object());
-  Isolate* isolate = global->GetIsolate();
-  Factory* factory = isolate->factory();
+  Factory* factory = isolate()->factory();
 
   LookupIterator it1(global, factory->NewStringFromAsciiChecked(object_name),
                      LookupIterator::OWN_SKIP_INTERCEPTOR);
   Handle<Object> object = Object::GetProperty(&it1).ToHandleChecked();
   LookupIterator it2(object, factory->NewStringFromAsciiChecked("prototype"),
                      LookupIterator::OWN_SKIP_INTERCEPTOR);
   Handle<Object> prototype = Object::GetProperty(&it2).ToHandleChecked();
+  InstallOneBuiltinFunction(prototype, method_name, builtin_name);
+}
 
-  LookupIterator it3(prototype, factory->NewStringFromAsciiChecked(method_name),
-                     LookupIterator::OWN_SKIP_INTERCEPTOR);
-  Handle<Object> function = Object::GetProperty(&it3).ToHandleChecked();
+void Genesis::InstallOneBuiltinFunction(Handle<Object> prototype,
+                                        const char* method_name,
+                                        Builtins::Name builtin_name) {
+  LookupIterator it(
+      prototype, isolate()->factory()->NewStringFromAsciiChecked(method_name),
+      LookupIterator::OWN_SKIP_INTERCEPTOR);
+  Handle<Object> function = Object::GetProperty(&it).ToHandleChecked();
   Handle<JSFunction>::cast(function)->set_code(
-      isolate->builtins()->builtin(builtin_name));
+      isolate()->builtins()->builtin(builtin_name));
   Handle<JSFunction>::cast(function)->shared()->set_code(
-      isolate->builtins()->builtin(builtin_name));
+      isolate()->builtins()->builtin(builtin_name));
 }
 
 void Genesis::InitializeGlobal_experimental_fast_array_builtins() {
   if (!FLAG_experimental_fast_array_builtins) return;
 
   // Insert experimental fast array builtins here.
   InstallOneBuiltinFunction("Array", "filter", Builtins::kArrayFilter);
   InstallOneBuiltinFunction("Array", "map", Builtins::kArrayMap);
+  Handle<Object> typed_array_prototype(
+      native_context()->typed_array_prototype(), isolate());
+  InstallOneBuiltinFunction(typed_array_prototype, "every",

[mvstanton, 2017/03/28 15:01:24]

Maybe it makes sense to remove InstallOneBuiltinFunction(char *name, ...),

And just look up the array prototype here. This is the only place
InstallOneBuiltinFunction is called.

+                            Builtins::kTypedArrayPrototypeEvery);
+  InstallOneBuiltinFunction(typed_array_prototype, "some",
+                            Builtins::kTypedArrayPrototypeSome);
 }
 
 void Genesis::InitializeGlobal_harmony_sharedarraybuffer() {
   if (!FLAG_harmony_sharedarraybuffer) return;
 
   Handle<JSGlobalObject> global(native_context()->global_object());
   Isolate* isolate = global->GetIsolate();
   Factory* factory = isolate->factory();
 
   Handle<JSFunction> shared_array_buffer_fun =
@@ skipping 1368 matching lines @@
 }
 
 
 // Called when the top-level V8 mutex is destroyed.
 void Bootstrapper::FreeThreadResources() {
   DCHECK(!IsActive());
 }
 
 }  // namespace internal
 }  // namespace v8