GM: add --ignoreFailuresFile as an alternative to --ignoreTests

GM: add --ignoreFailuresFile as an alternative to --ignoreTests

(moved to new review at https://codereview.chromium.org/29203002 due to gcl/Rietveld madness)

This will allow the user to specify the tests to ignore failure on as a file,
rather than listing them out in the command line (and thus busting the
line length limit on Android).

BUG=skia:1730

[borenet, 2013-10-17 19:33:33]

This code LGTM but I'm a bit confused - I thought we were going to try a
buildbot-side approach in Python in which we "patch" the GM expectations file
with the ignored tests file.

[epoger, 2013-10-17 19:37:40]

On 2013/10/17 19:33:33, borenet wrote:
> This code LGTM but I'm a bit confused - I thought we were going to try a
> buildbot-side approach in Python in which we "patch" the GM expectations file
> with the ignored tests file.

Yeah, that is what we discussed live.  But I had already written most of this CL
by then, and I figured I would see if it was pretty easy to finish (and it was).

There are advantages and uglinesses both ways. :-)

[scroggo, 2013-10-18 14:32:48]

https://codereview.chromium.org/27752002/diff/1/gm/gmmain.cpp
File gm/gmmain.cpp (right):

https://codereview.chromium.org/27752002/diff/1/gm/gmmain.cpp#newcode2066
gm/gmmain.cpp:2066: for (int i = 0; i < FLAGS_ignoreTests.count(); i++) {
If this is deprecated, should we add a message when it's used? The help string
is only shown if the user needs help (so they may never see it), and the help
string is rather large due to all the possible options.

https://codereview.chromium.org/27752002/diff/1/gm/tests/run.sh
File gm/tests/run.sh (right):

https://codereview.chromium.org/27752002/diff/1/gm/tests/run.sh#newcode205
gm/tests/run.sh:205: FAILURES_FILE="$GM_INPUTS/ignoreFailureFile"
Did you add this file?

[epoger, 2013-10-18 14:36:12]

https://codereview.chromium.org/27752002/diff/1/gm/gmmain.cpp
File gm/gmmain.cpp (right):

https://codereview.chromium.org/27752002/diff/1/gm/gmmain.cpp#newcode2066
gm/gmmain.cpp:2066: for (int i = 0; i < FLAGS_ignoreTests.count(); i++) {
On 2013/10/18 14:32:49, scroggo wrote:
> If this is deprecated, should we add a message when it's used? The help string
> is only shown if the user needs help (so they may never see it), and the help
> string is rather large due to all the possible options.

My intent is to follow up this CL with more CLs that:
1. make buildbots use the new flag instead of the old one
2. wait for it to work through buildbots
3. remove the old flag

I'm open to other transition plans... I figured that nobody but the buildbots
are really using this flag currently anyway.

Any thoughts?

https://codereview.chromium.org/27752002/diff/1/gm/tests/run.sh
File gm/tests/run.sh (right):

https://codereview.chromium.org/27752002/diff/1/gm/tests/run.sh#newcode205
gm/tests/run.sh:205: FAILURES_FILE="$GM_INPUTS/ignoreFailureFile"
On 2013/10/18 14:32:49, scroggo wrote:
> Did you add this file?

Yes, it's new; its contents are filled in by the lines below.

[epoger, 2013-10-18 14:43:21]

moved to new review at https://codereview.chromium.org/29203002 due to
gcl/Rietveld madness