GM: add --ignoreFailuresFile as an alternative to --ignoreTests

GM: add --ignoreFailuresFile as an alternative to --ignoreTests

(moved from old review at https://codereview.chromium.org/27752002/ )

This will allow the user to specify the tests to ignore failure on as a file,
rather than listing them out in the command line (and thus busting the
line length limit on Android).
BUG=skia:1730
R=scroggo@google.com

Committed: https://code.google.com/p/skia/source/detail?r=11855

[epoger, 2013-10-18 14:45:02]

Patchset 1 was copied in from moved from old review at
https://codereview.chromium.org/27752002/ without any changes.

[scroggo, 2013-10-18 14:50:34]

lgtm

https://codereview.chromium.org/29203002/diff/1/gm/gmmain.cpp
File gm/gmmain.cpp (right):

https://codereview.chromium.org/29203002/diff/1/gm/gmmain.cpp#newcode2067
gm/gmmain.cpp:2067:
ignoreTestSubstrings.push_back(SkString(FLAGS_ignoreTests[i]));
On 2013/10/18 14:36:13, epoger wrote:
> On 2013/10/18 14:32:49, scroggo wrote:
> > If this is deprecated, should we add a message when it's used? The help
string
> > is only shown if the user needs help (so they may never see it), and the
help
> > string is rather large due to all the possible options.
> 
> My intent is to follow up this CL with more CLs that:
> 1. make buildbots use the new flag instead of the old one
> 2. wait for it to work through buildbots
> 3. remove the old flag
> 
> I'm open to other transition plans... I figured that nobody but the buildbots
> are really using this flag currently anyway.
> 
> Any thoughts?

That sounds fine to me.

https://codereview.chromium.org/29203002/diff/1/gm/tests/run.sh
File gm/tests/run.sh (right):

https://codereview.chromium.org/29203002/diff/1/gm/tests/run.sh#newcode205
gm/tests/run.sh:205: FAILURES_FILE="$GM_INPUTS/ignoreFailureFile"
On 2013/10/18 14:36:13, epoger wrote:
> On 2013/10/18 14:32:49, scroggo wrote:
> > Did you add this file?
> 
> Yes, it's new; its contents are filled in by the lines below.

Haha, of course. Thanks for the clarification.

[epoger, 2013-10-18 14:52:49]

Thanks, Leon... please take a look at patchset 2.

https://codereview.chromium.org/29203002/diff/20001/gm/gmmain.cpp
File gm/gmmain.cpp (right):

https://codereview.chromium.org/29203002/diff/20001/gm/gmmain.cpp#newcode2067
gm/gmmain.cpp:2067: gm_fprintf(stderr, "you are using deprecated --ignoreTests
flag\n");
Leon- I realized that, since I hadn't committed this yet (due to problems with
my checkout), I could add the warning you mentioned when someone uses the
deprecated flag.  How's it look to you?

https://codereview.chromium.org/29203002/diff/20001/gm/tests/outputs/compared...
File gm/tests/outputs/compared-against-empty-dir/output-expected/stderr (right):

https://codereview.chromium.org/29203002/diff/20001/gm/tests/outputs/compared...
gm/tests/outputs/compared-against-empty-dir/output-expected/stderr:1: GM: you
are using deprecated --ignoreTests flag
One of the other self-tests uses the deprecated flag, so it generates this
output now.

[scroggo, 2013-10-18 14:54:53]

lgtm

https://codereview.chromium.org/29203002/diff/20001/gm/gmmain.cpp
File gm/gmmain.cpp (right):

https://codereview.chromium.org/29203002/diff/20001/gm/gmmain.cpp#newcode2067
gm/gmmain.cpp:2067: gm_fprintf(stderr, "you are using deprecated --ignoreTests
flag\n");
On 2013/10/18 14:52:49, epoger wrote:
> Leon- I realized that, since I hadn't committed this yet (due to problems with
> my checkout), I could add the warning you mentioned when someone uses the
> deprecated flag.  How's it look to you?

Perfect. Thanks!

[epoger, 2013-10-18 14:55:49]

Committed patchset #2 manually as r11855 (presubmit successful).