Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: gm/tests/run.sh

Issue 27752002: GM: add --ignoreFailuresFile as an alternative to --ignoreTests (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gm/tests/run.sh
===================================================================
--- gm/tests/run.sh (revision 11844)
+++ gm/tests/run.sh (working copy)
@@ -201,8 +201,12 @@
gm_test "--verbose --hierarchy --match selftest1 $CONFIGS -r $GM_INPUTS/images/different-pixels" "$GM_OUTPUTS/compared-against-different-pixels-images"
gm_test "--verbose --hierarchy --match selftest1 $CONFIGS -r $GM_INPUTS/json/different-pixels.json" "$GM_OUTPUTS/compared-against-different-pixels-json"
-# Exercise --ignoreTests flag.
-gm_test "--verbose --hierarchy --match selftest1 --ignoreTests 8888/selfte $CONFIGS -r $GM_INPUTS/json/different-pixels.json" "$GM_OUTPUTS/ignoring-one-test"
+# Exercise --ignoreFailuresFile flag.
+FAILURES_FILE="$GM_INPUTS/ignoreFailureFile"
scroggo 2013/10/18 14:32:49 Did you add this file?
epoger 2013/10/18 14:36:13 Yes, it's new; its contents are filled in by the l
+echo "# Comment line" >$FAILURES_FILE
+echo "" >>$FAILURES_FILE
+echo "8888/selfte" >>$FAILURES_FILE
+gm_test "--verbose --hierarchy --match selftest1 --ignoreFailuresFile $FAILURES_FILE $CONFIGS -r $GM_INPUTS/json/different-pixels.json" "$GM_OUTPUTS/ignoring-one-test"
# Compare different pixels, but with a SUBSET of the expectations marked as
# ignore-failure.
« gm/gmmain.cpp ('K') | « gm/tests/outputs/ignoring-one-test/output-expected/command_line ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698