Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2775133002: M57: Properly clean up in PrintViewManager::RenderFrameCreated(). (Closed)

Created:
3 years, 9 months ago by Lei Zhang
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

M57: Properly clean up in PrintViewManager::RenderFrameCreated(). BUG=694382, 698622 Review-Url: https://codereview.chromium.org/2742853003 Cr-Commit-Position: refs/heads/master@{#457363} (cherry picked from commit 746da1cc6b2fbc2f725934542eedc49b41e5f17b) Review-Url: https://codereview.chromium.org/2775133002 . Cr-Commit-Position: refs/branch-heads/2987@{#881} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/8839f8f3d22dc169ede6edad06d75735dbf3c34a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -2 lines) Patch
M chrome/browser/printing/print_view_manager.cc View 2 chunks +3 lines, -2 lines 0 comments Download
A chrome/browser/printing/print_view_manager_unittest.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Lei Zhang
3 years, 9 months ago (2017-03-27 03:40:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8839f8f3d22dc169ede6edad06d75735dbf3c34a (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698