Properly clean up in PrintViewManager::RenderFrameCreated().

Properly clean up in PrintViewManager::RenderFrameCreated().

BUG=694382, 698622
Review-Url: https://codereview.chromium.org/2742853003
Cr-Commit-Position: refs/heads/master@{#457363}
Committed: https://chromium.googlesource.com/chromium/src/+/746da1cc6b2fbc2f725934542eedc49b41e5f17b

[Lei Zhang, 2017-03-10 03:15:30]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 03:15:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 03:34:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 03:34:38]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Lei Zhang, 2017-03-10 23:48:03]

thestig@chromium.org changed reviewers:
+ dcheng@chromium.org, nasko@chromium.org

[dcheng, 2017-03-11 06:21:10]

The change seems reasonable to me, but I'm wondering if we should have a test.

[nasko, 2017-03-13 21:33:57]

I agree with dcheng@ that having a test will be useful. Otherwise the change is
more or less a rubberstamp LGTM from me.

[Lei Zhang, 2017-03-15 09:24:52]

Description was changed from

==========
Properly clean up in PrintViewManager::RenderFrameCreated().

BUG=692488,698622
==========

to

==========
Properly clean up in PrintViewManager::RenderFrameCreated().

BUG=694382,698622
==========

[Lei Zhang, 2017-03-16 00:25:37]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 00:26:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2017-03-16 00:27:24]

I tried adding a browser test, but it (a) gave away the POC and (b) was rather
flaky. So I added a focused unit test to detect the error.

While trying to write a browser test, I noticed PrintPreviewDone() getting
called multiple times and failing its internal state DCHECK(). I ended up
handling that instead.

[commit-bot: I haz the power, 2017-03-16 01:38:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 01:38:14]

Dry run: This issue passed the CQ dry run.

[dcheng, 2017-03-16 05:55:47]

On 2017/03/16 00:27:24, Lei Zhang (super slow) wrote:
> I tried adding a browser test, but it (a) gave away the POC and (b) was rather
> flaky. So I added a focused unit test to detect the error.

Regarding (a), I don't think it's that big a deal. But I guess (b) is a problem
=)

> 
> While trying to write a browser test, I noticed PrintPreviewDone() getting
> called multiple times and failing its internal state DCHECK(). I ended up
> handling that instead.

LGTM

[Lei Zhang, 2017-03-16 06:06:40]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2017-03-16 06:06:41]

The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/2742853003/#ps20001
(title: "Add test")

[commit-bot: I haz the power, 2017-03-16 06:06:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 06:18:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489644400706460,
"parent_rev": "5095480ec3cb9b572e9a14f9d4a93f9d0b54b992", "commit_rev":
"746da1cc6b2fbc2f725934542eedc49b41e5f17b"}

[commit-bot: I haz the power, 2017-03-16 06:19:32]

Description was changed from

==========
Properly clean up in PrintViewManager::RenderFrameCreated().

BUG=694382,698622
==========

to

==========
Properly clean up in PrintViewManager::RenderFrameCreated().

BUG=694382,698622

Review-Url: https://codereview.chromium.org/2742853003
Cr-Commit-Position: refs/heads/master@{#457363}
Committed:
https://chromium.googlesource.com/chromium/src/+/746da1cc6b2fbc2f725934542eed...
==========

[commit-bot: I haz the power, 2017-03-16 06:19:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/746da1cc6b2fbc2f725934542eed...