Revert of Remove sandbox/win/tools.

Revert of Remove sandbox/win/tools. (patchset #1 id:1 of https://codereview.chromium.org/2773333002/ )

Reason for revert:
Compile failed on WinClang64.

https://uberchromegw.corp.google.com/i/chromium.win/builders/WinClang64%20%28dbg%29/builds/11236

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWinClang64__dbg_%2F11236%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout

[479/12131] CXX obj/sandbox/win/pocdll/handles.obj
FAILED: obj/sandbox/win/pocdll/handles.obj 
C:\b\c\goma_client/gomacc.exe ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes /FC @obj/sandbox/win/pocdll/handles.obj.rsp /c ../../sandbox/win/sandbox_poc/pocdll/handles.cc /Foobj/sandbox/win/pocdll/handles.obj /Fd"obj/sandbox/win/pocdll_cc.pdb"
C:\b\c\b\win_clang\src\sandbox\win\sandbox_poc\pocdll\handles.cc(7,10):  fatal error: 'sandbox/win/tools/finder/ntundoc.h' file not found
#include "sandbox/win/tools/finder/ntundoc.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Original issue's description:
> Remove sandbox/win/tools.
> 
> The files therein look unused, haven't been really touched since 2012, aren't
> referenced in any build files, and have some maintenance cost.
> 
> BUG=661774
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
> 
> Review-Url: https://codereview.chromium.org/2773333002
> Cr-Commit-Position: refs/heads/master@{#459696}
> Committed: https://chromium.googlesource.com/chromium/src/+/6625b2f764ae4efb0637215660500ba721b8a43d

TBR=wfh@chromium.org,thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=661774
Review-Url: https://codereview.chromium.org/2775123002
Cr-Commit-Position: refs/heads/master@{#459698}
Committed: https://chromium.googlesource.com/chromium/src/+/843ecf04f4af01faed28fdbb92db683944a06918

[hayato, 2017-03-27 03:39:15]

The CQ bit was checked by hayato@chromium.org

[hayato, 2017-03-27 03:39:15]

Created Revert of Remove sandbox/win/tools.

[commit-bot: I haz the power, 2017-03-27 03:39:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 03:40:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490585955346330, "parent_rev":
"b91d302ec822f5a1900e2e0479d98741c0fb6d73", "commit_rev":
"843ecf04f4af01faed28fdbb92db683944a06918"}

[commit-bot: I haz the power, 2017-03-27 03:41:16]

Description was changed from

==========
Revert of Remove sandbox/win/tools. (patchset #1 id:1 of
https://codereview.chromium.org/2773333002/ )

Reason for revert:
Compile failed on WinClang64.

https://uberchromegw.corp.google.com/i/chromium.win/builders/WinClang64%20%28...

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWinClang6...

[479/12131] CXX obj/sandbox/win/pocdll/handles.obj
FAILED: obj/sandbox/win/pocdll/handles.obj 
C:\b\c\goma_client/gomacc.exe
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo
/showIncludes /FC @obj/sandbox/win/pocdll/handles.obj.rsp /c
../../sandbox/win/sandbox_poc/pocdll/handles.cc
/Foobj/sandbox/win/pocdll/handles.obj /Fd"obj/sandbox/win/pocdll_cc.pdb"
C:\b\c\b\win_clang\src\sandbox\win\sandbox_poc\pocdll\handles.cc(7,10):  fatal
error: 'sandbox/win/tools/finder/ntundoc.h' file not found
#include "sandbox/win/tools/finder/ntundoc.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Original issue's description:
> Remove sandbox/win/tools.
> 
> The files therein look unused, haven't been really touched since 2012, aren't
> referenced in any build files, and have some maintenance cost.
> 
> BUG=661774
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
> 
> Review-Url: https://codereview.chromium.org/2773333002
> Cr-Commit-Position: refs/heads/master@{#459696}
> Committed:
https://chromium.googlesource.com/chromium/src/+/6625b2f764ae4efb063721566050...

TBR=wfh@chromium.org,thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=661774
==========

to

==========
Revert of Remove sandbox/win/tools. (patchset #1 id:1 of
https://codereview.chromium.org/2773333002/ )

Reason for revert:
Compile failed on WinClang64.

https://uberchromegw.corp.google.com/i/chromium.win/builders/WinClang64%20%28...

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWinClang6...

[479/12131] CXX obj/sandbox/win/pocdll/handles.obj
FAILED: obj/sandbox/win/pocdll/handles.obj 
C:\b\c\goma_client/gomacc.exe
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo
/showIncludes /FC @obj/sandbox/win/pocdll/handles.obj.rsp /c
../../sandbox/win/sandbox_poc/pocdll/handles.cc
/Foobj/sandbox/win/pocdll/handles.obj /Fd"obj/sandbox/win/pocdll_cc.pdb"
C:\b\c\b\win_clang\src\sandbox\win\sandbox_poc\pocdll\handles.cc(7,10):  fatal
error: 'sandbox/win/tools/finder/ntundoc.h' file not found
#include "sandbox/win/tools/finder/ntundoc.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Original issue's description:
> Remove sandbox/win/tools.
> 
> The files therein look unused, haven't been really touched since 2012, aren't
> referenced in any build files, and have some maintenance cost.
> 
> BUG=661774
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
> 
> Review-Url: https://codereview.chromium.org/2773333002
> Cr-Commit-Position: refs/heads/master@{#459696}
> Committed:
https://chromium.googlesource.com/chromium/src/+/6625b2f764ae4efb063721566050...

TBR=wfh@chromium.org,thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=661774

Review-Url: https://codereview.chromium.org/2775123002
Cr-Commit-Position: refs/heads/master@{#459698}
Committed:
https://chromium.googlesource.com/chromium/src/+/843ecf04f4af01faed28fdbb92db...
==========

[commit-bot: I haz the power, 2017-03-27 03:41:17]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/843ecf04f4af01faed28fdbb92db...

[Will Harris, 2017-03-27 03:59:53]

On 2017/03/27 03:41:17, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/843ecf04f4af01faed28fdbb92db...

lgtm thanks for the reverts. Any reason why this wasn't picked up by the
trybots?

[hayato, 2017-03-27 04:06:20]

On 2017/03/27 at 03:59:53, wfh wrote:
> On 2017/03/27 03:41:17, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
https://chromium.googlesource.com/chromium/src/+/843ecf04f4af01faed28fdbb92db...
> 
> lgtm thanks for the reverts. Any reason why this wasn't picked up by the
trybots?

I am not sure. I just reverted this as a chromium sheriff.

[Nico, 2017-03-27 14:19:55]

On 2017/03/27 03:59:53, Will Harris wrote:
> On 2017/03/27 03:41:17, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
>
https://chromium.googlesource.com/chromium/src/+/843ecf04f4af01faed28fdbb92db...
> 
> lgtm thanks for the reverts. Any reason why this wasn't picked up by the
> trybots?

It's because the trybots only build tests they want to run. But some waterfall
bots build all targets. pocdll isn't used by anything in the build, and trybots
aren't configured to build it. Is pocdll used by anyone still?

Options:
1. Delete pocdll too
2. Move ntundoc.h to pocdll, reland with that change, update win trybot config
to build pocdll

Which one do you want me to do?

[Nico, 2017-03-27 14:22:45]

On Mon, Mar 27, 2017 at 10:19 AM, <thakis@chromium.org> wrote:

> On 2017/03/27 03:59:53, Will Harris wrote:
> > On 2017/03/27 03:41:17, commit-bot: I haz the power wrote:
> > > Committed patchset #1 (id:1) as
> > >
> >
> https://chromium.googlesource.com/chromium/src/+/
> 843ecf04f4af01faed28fdbb92db683944a06918
> >
> > lgtm thanks for the reverts. Any reason why this wasn't picked up by the
> > trybots?
>
> It's because the trybots only build tests they want to run. But some
> waterfall
> bots build all targets. pocdll isn't used by anything in the build, and
> trybots
> aren't configured to build it. Is pocdll used by anyone still?
>
> Options:
> 1. Delete pocdll too
> 2. Move ntundoc.h to pocdll, reland with that change, update win trybot
> config
> to build pocdll
>
> Which one do you want me to do?
>

(wfh: This was a question to you. That wasn't super clear now that I look
at my message in gmail, sorry.)

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Will Harris, 2017-03-27 14:30:32]

On 2017/03/27 14:22:45, Nico wrote:
> On Mon, Mar 27, 2017 at 10:19 AM, <mailto:thakis@chromium.org> wrote:
> 
> > On 2017/03/27 03:59:53, Will Harris wrote:
> > > On 2017/03/27 03:41:17, commit-bot: I haz the power wrote:
> > > > Committed patchset #1 (id:1) as
> > > >
> > >
> > https://chromium.googlesource.com/chromium/src/+/
> > 843ecf04f4af01faed28fdbb92db683944a06918
> > >
> > > lgtm thanks for the reverts. Any reason why this wasn't picked up by the
> > > trybots?
> >
> > It's because the trybots only build tests they want to run. But some
> > waterfall
> > bots build all targets. pocdll isn't used by anything in the build, and
> > trybots
> > aren't configured to build it. Is pocdll used by anyone still?
> >
> > Options:
> > 1. Delete pocdll too
> > 2. Move ntundoc.h to pocdll, reland with that change, update win trybot
> > config
> > to build pocdll
> >
> > Which one do you want me to do?
> >
> 
> (wfh: This was a question to you. That wasn't super clear now that I look
> at my message in gmail, sorry.)
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

I have certainly used pocdll when doing sandbox development, but since it has no
build files and the same functionality can be hacked together from sandbox
integration tests, I would be fine with deleting pocdll as well.