Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2773333002: Remove sandbox/win/tools. (Closed)

Created:
3 years, 9 months ago by Nico
Modified:
3 years, 8 months ago
Reviewers:
Will Harris
CC:
chromium-reviews, wfh+watch_chromium.org, pennymac+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove sandbox/win/tools. The files therein look unused, haven't been really touched since 2012, aren't referenced in any build files, and have some maintenance cost. BUG=661774 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng NOTRY=true Review-Url: https://codereview.chromium.org/2773333002 Cr-Original-Commit-Position: refs/heads/master@{#459696} Committed: https://chromium.googlesource.com/chromium/src/+/6625b2f764ae4efb0637215660500ba721b8a43d Review-Url: https://codereview.chromium.org/2773333002 Cr-Commit-Position: refs/heads/master@{#467366} Committed: https://chromium.googlesource.com/chromium/src/+/1f3923624ee0a8ae0f2ec3136e376ca3a2a5c028

Patch Set 1 #

Patch Set 2 : reland #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1733 lines) Patch
M sandbox/win/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/win/sandbox_poc/pocdll/handles.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + sandbox/win/sandbox_poc/pocdll/ntundoc.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D sandbox/win/tools/finder/finder.h View 1 chunk +0 lines, -144 lines 0 comments Download
D sandbox/win/tools/finder/finder.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D sandbox/win/tools/finder/finder.vcproj View 1 chunk +0 lines, -201 lines 0 comments Download
D sandbox/win/tools/finder/finder_fs.cc View 1 chunk +0 lines, -117 lines 0 comments Download
D sandbox/win/tools/finder/finder_kernel.cc View 1 chunk +0 lines, -248 lines 0 comments Download
D sandbox/win/tools/finder/finder_registry.cc View 1 chunk +0 lines, -93 lines 0 comments Download
D sandbox/win/tools/finder/main.cc View 1 chunk +0 lines, -147 lines 0 comments Download
D sandbox/win/tools/finder/ntundoc.h View 1 chunk +0 lines, -275 lines 0 comments Download
D sandbox/win/tools/launcher/launcher.cc View 1 chunk +0 lines, -270 lines 0 comments Download
D sandbox/win/tools/launcher/launcher.vcproj View 1 chunk +0 lines, -177 lines 0 comments Download

Messages

Total messages: 28 (18 generated)
Nico
3 years, 9 months ago (2017-03-26 02:13:09 UTC) #6
Will Harris
lgtm
3 years, 9 months ago (2017-03-27 03:07:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2773333002/1
3 years, 9 months ago (2017-03-27 03:07:32 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/6625b2f764ae4efb0637215660500ba721b8a43d
3 years, 9 months ago (2017-03-27 03:23:14 UTC) #14
hayato
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2775123002/ by hayato@chromium.org. ...
3 years, 9 months ago (2017-03-27 03:39:15 UTC) #15
tkent
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2773423002/ by tkent@chromium.org. ...
3 years, 9 months ago (2017-03-27 03:40:11 UTC) #16
findit-for-me
Findit confirmed this CL at revision 459696 as the culprit for failures in the build ...
3 years, 9 months ago (2017-03-27 03:44:17 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2773333002/20001
3 years, 8 months ago (2017-04-26 16:09:04 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2773333002/20001
3 years, 8 months ago (2017-04-26 17:23:37 UTC) #25
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 17:45:47 UTC) #28
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1f3923624ee0a8ae0f2ec3136e37...

Powered by Google App Engine
This is Rietveld 408576698