Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 2774843002: Pass AccessControlStatus to compileModule() (Closed)

Created:
3 years, 9 months ago by hiroshige
Modified:
3 years, 8 months ago
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass AccessControlStatus to compileModule() BUG=594639 Review-Url: https://codereview.chromium.org/2774843002 Cr-Commit-Position: refs/heads/master@{#462338} Committed: https://chromium.googlesource.com/chromium/src/+/c8cb5f2da2acc2d2da66c9e31957c0474e9978e7

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : build fix #

Patch Set 4 : Rebase and build fix #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Patch Set 7 : Fix build break. #

Patch Set 8 : const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -52 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptModule.h View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp View 1 2 3 4 5 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptModuleTest.cpp View 1 2 3 4 5 6 5 chunks +17 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp View 1 2 3 4 1 chunk +12 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Modulator.h View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoader.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoader.cpp View 3 chunks +9 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoaderTest.cpp View 1 2 3 4 5 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/resource/ScriptResource.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/resource/ScriptResource.cpp View 1 2 3 4 5 6 7 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/DummyModulator.h View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/DummyModulator.cpp View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/Resource.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/Resource.cpp View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 38 (31 generated)
hiroshige
3 years, 8 months ago (2017-04-05 22:59:12 UTC) #20
hiroshige
PTAL.
3 years, 8 months ago (2017-04-05 23:00:27 UTC) #22
kouhei (in TOK)
lgtm
3 years, 8 months ago (2017-04-05 23:54:55 UTC) #24
kouhei (in TOK)
+yhirano, haraken for bindings
3 years, 8 months ago (2017-04-05 23:55:34 UTC) #27
haraken
LGTM
3 years, 8 months ago (2017-04-06 01:13:50 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774843002/140001
3 years, 8 months ago (2017-04-06 03:02:26 UTC) #35
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 03:10:01 UTC) #38
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/c8cb5f2da2acc2d2da66c9e31957...

Powered by Google App Engine
This is Rietveld 408576698