Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/ScriptModuleTest.cpp

Issue 2774843002: Pass AccessControlStatus to compileModule() (Closed)
Patch Set: const Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "bindings/core/v8/ScriptModule.h" 5 #include "bindings/core/v8/ScriptModule.h"
6 6
7 #include "bindings/core/v8/V8BindingForTesting.h" 7 #include "bindings/core/v8/V8BindingForTesting.h"
8 #include "bindings/core/v8/V8PerContextData.h" 8 #include "bindings/core/v8/V8PerContextData.h"
9 #include "core/dom/ScriptModuleResolver.h" 9 #include "core/dom/ScriptModuleResolver.h"
10 #include "core/testing/DummyModulator.h" 10 #include "core/testing/DummyModulator.h"
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 ScriptModuleTestModulator::ScriptModuleTestModulator() 67 ScriptModuleTestModulator::ScriptModuleTestModulator()
68 : m_resolver(new TestScriptModuleResolver) {} 68 : m_resolver(new TestScriptModuleResolver) {}
69 69
70 DEFINE_TRACE(ScriptModuleTestModulator) { 70 DEFINE_TRACE(ScriptModuleTestModulator) {
71 visitor->trace(m_resolver); 71 visitor->trace(m_resolver);
72 DummyModulator::trace(visitor); 72 DummyModulator::trace(visitor);
73 } 73 }
74 74
75 TEST(ScriptModuleTest, compileSuccess) { 75 TEST(ScriptModuleTest, compileSuccess) {
76 V8TestingScope scope; 76 V8TestingScope scope;
77 ScriptModule module = 77 ScriptModule module = ScriptModule::compile(
78 ScriptModule::compile(scope.isolate(), "export const a = 42;", "foo.js"); 78 scope.isolate(), "export const a = 42;", "foo.js", SharableCrossOrigin);
79 ASSERT_FALSE(module.isNull()); 79 ASSERT_FALSE(module.isNull());
80 } 80 }
81 81
82 TEST(ScriptModuleTest, compileFail) { 82 TEST(ScriptModuleTest, compileFail) {
83 V8TestingScope scope; 83 V8TestingScope scope;
84 ScriptModule module = 84 ScriptModule module = ScriptModule::compile(scope.isolate(), "123 = 456",
85 ScriptModule::compile(scope.isolate(), "123 = 456", "foo.js"); 85 "foo.js", SharableCrossOrigin);
86 ASSERT_TRUE(module.isNull()); 86 ASSERT_TRUE(module.isNull());
87 } 87 }
88 88
89 TEST(ScriptModuleTest, equalAndHash) { 89 TEST(ScriptModuleTest, equalAndHash) {
90 V8TestingScope scope; 90 V8TestingScope scope;
91 91
92 ScriptModule moduleNull; 92 ScriptModule moduleNull;
93 ScriptModule moduleA = 93 ScriptModule moduleA = ScriptModule::compile(
94 ScriptModule::compile(scope.isolate(), "export const a = 'a';", "a.js"); 94 scope.isolate(), "export const a = 'a';", "a.js", SharableCrossOrigin);
95 ASSERT_FALSE(moduleA.isNull()); 95 ASSERT_FALSE(moduleA.isNull());
96 ScriptModule moduleB = 96 ScriptModule moduleB = ScriptModule::compile(
97 ScriptModule::compile(scope.isolate(), "export const b = 'b';", "b.js"); 97 scope.isolate(), "export const b = 'b';", "b.js", SharableCrossOrigin);
98 ASSERT_FALSE(moduleB.isNull()); 98 ASSERT_FALSE(moduleB.isNull());
99 Vector<char> moduleDeletedBuffer(sizeof(ScriptModule)); 99 Vector<char> moduleDeletedBuffer(sizeof(ScriptModule));
100 ScriptModule& moduleDeleted = 100 ScriptModule& moduleDeleted =
101 *reinterpret_cast<ScriptModule*>(moduleDeletedBuffer.data()); 101 *reinterpret_cast<ScriptModule*>(moduleDeletedBuffer.data());
102 HashTraits<ScriptModule>::constructDeletedValue(moduleDeleted, true); 102 HashTraits<ScriptModule>::constructDeletedValue(moduleDeleted, true);
103 103
104 EXPECT_EQ(moduleNull, moduleNull); 104 EXPECT_EQ(moduleNull, moduleNull);
105 EXPECT_EQ(moduleA, moduleA); 105 EXPECT_EQ(moduleA, moduleA);
106 EXPECT_EQ(moduleB, moduleB); 106 EXPECT_EQ(moduleB, moduleB);
107 EXPECT_EQ(moduleDeleted, moduleDeleted); 107 EXPECT_EQ(moduleDeleted, moduleDeleted);
(...skipping 19 matching lines...) Expand all
127 EXPECT_NE(DefaultHash<ScriptModule>::Hash::hash(moduleNull), 127 EXPECT_NE(DefaultHash<ScriptModule>::Hash::hash(moduleNull),
128 DefaultHash<ScriptModule>::Hash::hash(moduleA)); 128 DefaultHash<ScriptModule>::Hash::hash(moduleA));
129 EXPECT_NE(DefaultHash<ScriptModule>::Hash::hash(moduleNull), 129 EXPECT_NE(DefaultHash<ScriptModule>::Hash::hash(moduleNull),
130 DefaultHash<ScriptModule>::Hash::hash(moduleB)); 130 DefaultHash<ScriptModule>::Hash::hash(moduleB));
131 } 131 }
132 132
133 TEST(ScriptModuleTest, moduleRequests) { 133 TEST(ScriptModuleTest, moduleRequests) {
134 V8TestingScope scope; 134 V8TestingScope scope;
135 ScriptModule module = ScriptModule::compile( 135 ScriptModule module = ScriptModule::compile(
136 scope.isolate(), "import 'a'; import 'b'; export const c = 'c';", 136 scope.isolate(), "import 'a'; import 'b'; export const c = 'c';",
137 "foo.js"); 137 "foo.js", SharableCrossOrigin);
138 ASSERT_FALSE(module.isNull()); 138 ASSERT_FALSE(module.isNull());
139 139
140 auto requests = module.moduleRequests(scope.getScriptState()); 140 auto requests = module.moduleRequests(scope.getScriptState());
141 EXPECT_THAT(requests, ::testing::ContainerEq<Vector<String>>({"a", "b"})); 141 EXPECT_THAT(requests, ::testing::ContainerEq<Vector<String>>({"a", "b"}));
142 } 142 }
143 143
144 TEST(ScriptModuleTest, instantiateNoDeps) { 144 TEST(ScriptModuleTest, instantiateNoDeps) {
145 V8TestingScope scope; 145 V8TestingScope scope;
146 146
147 auto modulator = new ScriptModuleTestModulator(); 147 auto modulator = new ScriptModuleTestModulator();
148 auto resolver = modulator->testScriptModuleResolver(); 148 auto resolver = modulator->testScriptModuleResolver();
149 149
150 auto contextData = V8PerContextData::from(scope.context()); 150 auto contextData = V8PerContextData::from(scope.context());
151 contextData->setModulator(modulator); 151 contextData->setModulator(modulator);
152 152
153 ScriptModule module = 153 ScriptModule module = ScriptModule::compile(
154 ScriptModule::compile(scope.isolate(), "export const a = 42;", "foo.js"); 154 scope.isolate(), "export const a = 42;", "foo.js", SharableCrossOrigin);
155 ASSERT_FALSE(module.isNull()); 155 ASSERT_FALSE(module.isNull());
156 ScriptValue exception = module.instantiate(scope.getScriptState()); 156 ScriptValue exception = module.instantiate(scope.getScriptState());
157 ASSERT_TRUE(exception.isEmpty()); 157 ASSERT_TRUE(exception.isEmpty());
158 158
159 EXPECT_EQ(0u, resolver->resolveCount()); 159 EXPECT_EQ(0u, resolver->resolveCount());
160 } 160 }
161 161
162 TEST(ScriptModuleTest, instantiateWithDeps) { 162 TEST(ScriptModuleTest, instantiateWithDeps) {
163 V8TestingScope scope; 163 V8TestingScope scope;
164 164
165 auto modulator = new ScriptModuleTestModulator(); 165 auto modulator = new ScriptModuleTestModulator();
166 auto resolver = modulator->testScriptModuleResolver(); 166 auto resolver = modulator->testScriptModuleResolver();
167 167
168 auto contextData = V8PerContextData::from(scope.context()); 168 auto contextData = V8PerContextData::from(scope.context());
169 contextData->setModulator(modulator); 169 contextData->setModulator(modulator);
170 170
171 ScriptModule moduleA = 171 ScriptModule moduleA = ScriptModule::compile(
172 ScriptModule::compile(scope.isolate(), "export const a = 'a';", "foo.js"); 172 scope.isolate(), "export const a = 'a';", "foo.js", SharableCrossOrigin);
173 ASSERT_FALSE(moduleA.isNull()); 173 ASSERT_FALSE(moduleA.isNull());
174 resolver->pushScriptModule(moduleA); 174 resolver->pushScriptModule(moduleA);
175 175
176 ScriptModule moduleB = 176 ScriptModule moduleB = ScriptModule::compile(
177 ScriptModule::compile(scope.isolate(), "export const b = 'b';", "foo.js"); 177 scope.isolate(), "export const b = 'b';", "foo.js", SharableCrossOrigin);
178 ASSERT_FALSE(moduleB.isNull()); 178 ASSERT_FALSE(moduleB.isNull());
179 resolver->pushScriptModule(moduleB); 179 resolver->pushScriptModule(moduleB);
180 180
181 ScriptModule module = ScriptModule::compile( 181 ScriptModule module = ScriptModule::compile(
182 scope.isolate(), "import 'a'; import 'b'; export const c = 123;", "c.js"); 182 scope.isolate(), "import 'a'; import 'b'; export const c = 123;", "c.js",
183 SharableCrossOrigin);
183 ASSERT_FALSE(module.isNull()); 184 ASSERT_FALSE(module.isNull());
184 ScriptValue exception = module.instantiate(scope.getScriptState()); 185 ScriptValue exception = module.instantiate(scope.getScriptState());
185 ASSERT_TRUE(exception.isEmpty()); 186 ASSERT_TRUE(exception.isEmpty());
186 187
187 ASSERT_EQ(2u, resolver->resolveCount()); 188 ASSERT_EQ(2u, resolver->resolveCount());
188 EXPECT_EQ("a", resolver->specifiers()[0]); 189 EXPECT_EQ("a", resolver->specifiers()[0]);
189 EXPECT_EQ("b", resolver->specifiers()[1]); 190 EXPECT_EQ("b", resolver->specifiers()[1]);
190 } 191 }
191 192
192 } // namespace 193 } // namespace
193 194
194 } // namespace blink 195 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698