Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2774813002: Hang Monitor UMA (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by amaralp
Modified:
2 months, 3 weeks ago
Reviewers:
aelias, Ilya Sherman
CC:
asvitkine+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Hang Monitor UMA Adding UMA stats for how long the renderer hangs according to the HangMonitor functions. BUG=148136 Review-Url: https://codereview.chromium.org/2774813002 Cr-Commit-Position: refs/heads/master@{#461035} Committed: https://chromium.googlesource.com/chromium/src/+/7a31d37dd9d762e402b316eb9c02b58bf1c66342

Patch Set 1 #

Total comments: 3

Patch Set 2 : fixing nits #

Patch Set 3 : fixed typo #

Patch Set 4 : fixed typo and period #

Messages

Total messages: 19 (12 generated)
amaralp
PTAL
3 months ago (2017-03-24 00:24:43 UTC) #4
aelias
lgtm
3 months ago (2017-03-24 01:04:28 UTC) #5
amaralp
Added isherman@ for tools/metrics OWNER
3 months ago (2017-03-24 01:36:47 UTC) #9
Ilya Sherman
LGTM % nits: https://codereview.chromium.org/2774813002/diff/1/content/browser/renderer_host/render_widget_host_impl.cc File content/browser/renderer_host/render_widget_host_impl.cc (right): https://codereview.chromium.org/2774813002/diff/1/content/browser/renderer_host/render_widget_host_impl.cc#newcode976 content/browser/renderer_host/render_widget_host_impl.cc:976: if (!hang_start_time_.is_null()) nit: Please use curly ...
3 months ago (2017-03-24 21:16:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774813002/60001
2 months, 3 weeks ago (2017-03-31 03:10:54 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/7a31d37dd9d762e402b316eb9c02b58bf1c66342
2 months, 3 weeks ago (2017-03-31 04:49:15 UTC) #18
findit-for-me
2 months, 3 weeks ago (2017-03-31 07:06:09 UTC) #19
Message was sent while issue was closed.
Findit identified this CL at revision 461035 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cb946e318