Hang Monitor UMA

Hang Monitor UMA

Adding UMA stats for how long the renderer hangs according to the
HangMonitor functions.

BUG=148136
Review-Url: https://codereview.chromium.org/2774813002
Cr-Commit-Position: refs/heads/master@{#461035}
Committed: https://chromium.googlesource.com/chromium/src/+/7a31d37dd9d762e402b316eb9c02b58bf1c66342

[amaralp, 2017-03-24 00:23:29]

The CQ bit was checked by amaralp@chromium.org to run a CQ dry run

[amaralp, 2017-03-24 00:23:48]

amaralp@chromium.org changed reviewers:
+ aelias@chromium.org

[commit-bot: I haz the power, 2017-03-24 00:23:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[amaralp, 2017-03-24 00:24:43]

PTAL

[aelias_OOO_until_Jul13, 2017-03-24 01:04:28]

lgtm

[commit-bot: I haz the power, 2017-03-24 01:30:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 01:30:36]

Dry run: This issue passed the CQ dry run.

[amaralp, 2017-03-24 01:36:14]

amaralp@chromium.org changed reviewers:
+ isherman@chromium.org

[amaralp, 2017-03-24 01:36:47]

Added isherman@ for tools/metrics OWNER

[Ilya Sherman, 2017-03-24 21:16:19]

LGTM % nits:

https://codereview.chromium.org/2774813002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_impl.cc (right):

https://codereview.chromium.org/2774813002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_impl.cc:976: if
(!hang_start_time_.is_null())
nit: Please use curly braces, since the body of this if-stmt spans multiple
lines of text.

https://codereview.chromium.org/2774813002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_impl.cc:994: hang_start_time_ =
TimeTicks();
Could you please factor out these four lines of shared code into a small helper
function?

https://codereview.chromium.org/2774813002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2774813002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:29983: +    monitor.
Please document when this is recorded -- when the renderer returns to being
responsive?

[amaralp, 2017-03-31 01:53:19]

The CQ bit was checked by amaralp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 01:53:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[amaralp, 2017-03-31 03:10:36]

The CQ bit was checked by amaralp@chromium.org

[amaralp, 2017-03-31 03:10:37]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org,
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2774813002/#ps60001
(title: "fixed typo and period")

[commit-bot: I haz the power, 2017-03-31 03:10:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 04:48:28]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490929836679980,
"parent_rev": "c631cd11f112484251cf04ae4845cc747b5c1aaf", "commit_rev":
"7a31d37dd9d762e402b316eb9c02b58bf1c66342"}

[commit-bot: I haz the power, 2017-03-31 04:49:14]

Description was changed from

==========
Hang Monitor UMA

Adding UMA stats for how long the renderer hangs according to the
HangMonitor functions.

BUG=148136
==========

to

==========
Hang Monitor UMA

Adding UMA stats for how long the renderer hangs according to the
HangMonitor functions.

BUG=148136

Review-Url: https://codereview.chromium.org/2774813002
Cr-Commit-Position: refs/heads/master@{#461035}
Committed:
https://chromium.googlesource.com/chromium/src/+/7a31d37dd9d762e402b316eb9c02...
==========

[commit-bot: I haz the power, 2017-03-31 04:49:15]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/7a31d37dd9d762e402b316eb9c02...

[findit-for-me, 2017-03-31 07:06:09]

Findit identified this CL at revision 461035 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...