Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2774763003: needsPaintInvalidation() should not return true for selection. (Closed)

Created:
3 years, 9 months ago by rune
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

needsPaintInvalidation() should not return true for selection. In [1] we introduced a paint invalidation constant for repainting selection. needsPaintInvalidation() started to also return true when only the selection needed paint invalidation. Callers of that method assumes that true will cause at least a full element repaint which made us skip setting the diff to invalidate the object and only invalidate the selection in some cases. Instead, only return true for PaintInvalidationObject and PaintInvalidationSubtree. [1] https://crrev.com/eff357ef R=mstensho@opera.com BUG=697337 Review-Url: https://codereview.chromium.org/2727843004 Cr-Commit-Position: refs/heads/master@{#454564} (cherry picked from commit c63e571885b21aa510dc323ecb1c5bc18f1ed29b) Review-Url: https://codereview.chromium.org/2774763003 . Cr-Commit-Position: refs/branch-heads/3029@{#406} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/5bedd07e8a1c07c0b8cb94b02b9b38d7b81896e0

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
rune
3 years, 9 months ago (2017-03-24 10:46:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5bedd07e8a1c07c0b8cb94b02b9b38d7b81896e0.

Powered by Google App Engine
This is Rietveld 408576698