Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issue 2774633002: Reenable History and Reading List EG tests. (Closed)

Created:
3 years, 9 months ago by lpromero
Modified:
3 years, 9 months ago
Reviewers:
gambard
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, stkhapugin, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reenable History and Reading List EG tests. The tests were disabled because of an underling issue fixed in https://codereview.chromium.org/2756193003/. BUG=704403, 704401 R=gambard@chromium.org Review-Url: https://codereview.chromium.org/2774633002 Cr-Commit-Position: refs/heads/master@{#459136} Committed: https://chromium.googlesource.com/chromium/src/+/d2b51af46553840e92c3b1f860b6ba13678c7852

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -20 lines) Patch
M ios/chrome/browser/ui/history/history_ui_egtest.mm View 5 chunks +6 lines, -12 lines 0 comments Download
M ios/chrome/browser/ui/reading_list/reading_list_egtest.mm View 4 chunks +4 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (9 generated)
lpromero
3 years, 9 months ago (2017-03-23 11:54:42 UTC) #1
gambard
lgtm
3 years, 9 months ago (2017-03-23 15:55:58 UTC) #7
commit-bot: I haz the power
This CL has an open dependency (Issue 2756193003 Patch 1). Please resolve the dependency and ...
3 years, 9 months ago (2017-03-23 15:56:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774633002/1
3 years, 9 months ago (2017-03-23 17:42:57 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 17:55:17 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d2b51af46553840e92c3b1f860b6...

Powered by Google App Engine
This is Rietveld 408576698