Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: ios/chrome/browser/ui/history/history_ui_egtest.mm

Issue 2774633002: Reenable History and Reading List EG tests. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/ui/reading_list/reading_list_egtest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/history/history_ui_egtest.mm
diff --git a/ios/chrome/browser/ui/history/history_ui_egtest.mm b/ios/chrome/browser/ui/history/history_ui_egtest.mm
index a1fa66123f8c89f9b51e2beefc0ea7ef897988a8..4f49008b4b789481360ba259bf691ebf4a382a82 100644
--- a/ios/chrome/browser/ui/history/history_ui_egtest.mm
+++ b/ios/chrome/browser/ui/history/history_ui_egtest.mm
@@ -234,15 +234,13 @@ void MockSignIn() {
#pragma mark Tests
// Tests that no history is shown if there has been no navigation.
-// TODO(crbug.com/704403): Re-enable this test.
-- (void)DISABLED_testDisplayNoHistory {
+- (void)testDisplayNoHistory {
[self openHistoryPanel];
[self assertNoHistoryShown];
}
// Tests that the history panel displays navigation history.
-// TODO(crbug.com/704403): Re-enable this test.
-- (void)DISABLED_testDisplayHistory {
+- (void)testDisplayHistory {
[self loadTestURLs];
[self openHistoryPanel];
@@ -262,8 +260,7 @@ void MockSignIn() {
}
// Tests that history is not changed after performing back navigation.
-// TODO(crbug.com/704403): Re-enable this test.
-- (void)DISABLED_testHistoryUpdateAfterBackNavigation {
+- (void)testHistoryUpdateAfterBackNavigation {
[ChromeEarlGrey loadURL:_URL1];
[ChromeEarlGrey loadURL:_URL2];
@@ -283,8 +280,7 @@ void MockSignIn() {
// Test that history displays a message about entries only if the user is logged
// in, and that tapping on the link in the message opens a new tab with the sync
// help page.
-// TODO(crbug.com/704403): Re-enable this test.
-- (void)DISABLED_testHistoryEntriesStatusCell {
+- (void)testHistoryEntriesStatusCell {
[self loadTestURLs];
[self openHistoryPanel];
// Assert that no message is shown when the user is not signed in.
@@ -317,8 +313,7 @@ void MockSignIn() {
}
// Tests that searching history displays only entries matching the search term.
-// TODO(crbug.com/704403): Re-enable this test.
-- (void)DISABLED_testSearchHistory {
+- (void)testSearchHistory {
[self loadTestURLs];
[self openHistoryPanel];
[[EarlGrey selectElementWithMatcher:SearchIconButton()]
@@ -337,8 +332,7 @@ void MockSignIn() {
}
// Tests deletion of history entries.
-// TODO(crbug.com/704403): Re-enable this test.
-- (void)DISABLED_testDeleteHistory {
+- (void)testDeleteHistory {
[self loadTestURLs];
[self openHistoryPanel];
« no previous file with comments | « no previous file | ios/chrome/browser/ui/reading_list/reading_list_egtest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698