Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 2774553003: Fast body iteration for objects without unboxed fields. (Closed)

Created:
3 years, 9 months ago by ulan
Modified:
3 years, 9 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Fast body iteration for objects without unboxed fields. Currently BodyDescriptorBase::IterateBodyImpl does a run-time check for obj->map()->HasFastPointerLayout(), which is redundant for all non-JSObject heap objects. BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2774553003 Cr-Commit-Position: refs/heads/master@{#44111} Committed: https://chromium.googlesource.com/v8/v8/+/dae6e43d38c0f66a49f66cfd7eb2f7113f054e68

Patch Set 1 #

Patch Set 2 : simplify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -27 lines) Patch
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects-body-descriptors.h View 1 3 chunks +5 lines, -6 lines 0 comments Download
M src/objects-body-descriptors-inl.h View 1 11 chunks +33 lines, -20 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
ulan
PTAL.
3 years, 9 months ago (2017-03-23 19:21:36 UTC) #2
ulan
Simplified as we discussed offline.
3 years, 9 months ago (2017-03-24 14:07:52 UTC) #4
Igor Sheludko
A lot of unrelated formatting, but lgtm.
3 years, 9 months ago (2017-03-24 14:12:46 UTC) #5
ulan
On 2017/03/24 14:12:46, Igor Sheludko wrote: > A lot of unrelated formatting, but lgtm. That's ...
3 years, 9 months ago (2017-03-24 14:14:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774553003/20001
3 years, 9 months ago (2017-03-24 14:14:15 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 14:42:59 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/dae6e43d38c0f66a49f66cfd7eb2f7113f0...

Powered by Google App Engine
This is Rietveld 408576698